Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for memcached1.5 and redis5.0 parameter group families. #54571

Merged
merged 1 commit into from
Apr 5, 2019

Conversation

psharkey
Copy link
Contributor

@psharkey psharkey commented Mar 29, 2019

SUMMARY

Adding support for memcached1.5 and redis5.0 parameter group families.
Fixes #53543

The original issue was for redis5.0 only, this adds memcached1.5 as well.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

elasticache_parameter_group

ADDITIONAL INFORMATION
STEPS TO TEST
- name: Create Elasticache Parameter Group
  elasticache_parameter_group:
    state: present
    name: "{{ item | regex_replace('\\.', '') }}-testing-group"
    group_family: "{{ item }}"
    description: 'testing-group'
  register: parameter_groups
  with_items:
    - memcached1.5
    - redis5.0

- debug: var=parameter_groups.results
TEST RESULTS
ok: [control-mine] => {
    "parameter_groups.results": [
        {
            "_ansible_ignore_errors": null,
            "_ansible_item_label": "memcached1.5",
            "_ansible_item_result": true,
            "_ansible_no_log": false,
            "_ansible_parsed": true,
            "changed": true,
            "elasticache": {
                "cache_parameter_group": {
                    "cache_parameter_group_family": "memcached1.5",
                    "cache_parameter_group_name": "memcached15-testing-group",
                    "description": "testing-group"
                },
                "response_metadata": {
                    "http_headers": {
                        "content-length": "567",
                        "content-type": "text/xml",
                        "date": "Fri, 29 Mar 2019 01:35:28 GMT",
                        "x-amzn-requestid": "ef3e6601-51c2-11e9-a9f9-05153ba79039"
                    },
                    "http_status_code": 200,
                    "request_id": "ef3e6601-51c2-11e9-a9f9-05153ba79039",
                    "retry_attempts": 0
                }
            },
            "failed": false,
            "invocation": {
                "module_args": {
                    "aws_access_key": null,
                    "aws_region": "eu-west-1",
                    "aws_secret_key": null,
                    "description": "testing-group",
                    "ec2_url": null,
                    "group_family": "memcached1.5",
                    "name": "memcached15-testing-group",
                    "profile": null,
                    "region": "eu-west-1",
                    "security_token": null,
                    "state": "present",
                    "validate_certs": true,
                    "values": null
                }
            },
            "item": "memcached1.5"
        },
        {
            "_ansible_ignore_errors": null,
            "_ansible_item_label": "redis5.0",
            "_ansible_item_result": true,
            "_ansible_no_log": false,
            "_ansible_parsed": true,
            "changed": true,
            "elasticache": {
                "cache_parameter_group": {
                    "cache_parameter_group_family": "redis5.0",
                    "cache_parameter_group_name": "redis50-testing-group",
                    "description": "testing-group"
                },
                "response_metadata": {
                    "http_headers": {
                        "content-length": "559",
                        "content-type": "text/xml",
                        "date": "Fri, 29 Mar 2019 01:35:29 GMT",
                        "x-amzn-requestid": "efca2ba3-51c2-11e9-8a00-4989f9e453b7"
                    },
                    "http_status_code": 200,
                    "request_id": "efca2ba3-51c2-11e9-8a00-4989f9e453b7",
                    "retry_attempts": 0
                }
            },
            "failed": false,
            "invocation": {
                "module_args": {
                    "aws_access_key": null,
                    "aws_region": "eu-west-1",
                    "aws_secret_key": null,
                    "description": "testing-group",
                    "ec2_url": null,
                    "group_family": "redis5.0",
                    "name": "redis50-testing-group",
                    "profile": null,
                    "region": "eu-west-1",
                    "security_token": null,
                    "state": "present",
                    "validate_certs": true,
                    "values": null
                }
            },
            "item": "redis5.0"
        }
    ]
}

@ansibot
Copy link
Contributor

ansibot commented Mar 29, 2019

@ansibot
Copy link
Contributor

ansibot commented Mar 29, 2019

@psharkey, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 aws bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:community This issue/PR relates to code supported by the Ansible community. feature This issue/PR relates to a feature request. and removed new_contributor This PR is the first contribution by a new community member. labels Mar 29, 2019
@willthames willthames merged commit a390510 into ansible:devel Apr 5, 2019
@willthames
Copy link
Contributor

Thanks @psharkey

@psharkey
Copy link
Contributor Author

psharkey commented Apr 5, 2019

@willthames Thanks for reviewing and merging!

@psharkey psharkey deleted the i-53543 branch April 5, 2019 13:54
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Apr 9, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.8 This issue/PR affects Ansible v2.8 aws bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elasticache_parameter_group doesn't support group_family redis5.0
4 participants