Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pollute include_variables #54687

Merged
merged 7 commits into from Apr 9, 2019
Merged

Don't pollute include_variables #54687

merged 7 commits into from Apr 9, 2019

Conversation

sivel
Copy link
Member

@sivel sivel commented Apr 1, 2019 •
edited

SUMMARY

Don't pollute include_variables which are in reality task args

Fixes #51667. Fixes #54618.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/playbook/included_file.py

ADDITIONAL INFORMATION

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 1, 2019
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. support:community This issue/PR relates to code supported by the Ansible community. and removed ci_verified Changes made in this PR are causing tests to fail. labels Apr 1, 2019
@sivel sivel mentioned this pull request Apr 3, 2019
Closed
@mkrizek mkrizek mentioned this pull request Apr 5, 2019
Closed
@sivel sivel changed the title [WIP] Don't pollute include_variables Don't pollute include_variables Apr 8, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. core_review In order to be merged, this PR must follow the core review workflow. labels Apr 8, 2019
@sivel sivel requested a review from bcoca April 9, 2019 14:22
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 9, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Apr 9, 2019
@sivel sivel merged commit fbf2d5d into ansible:devel Apr 9, 2019
@bcoca bcoca added this to Merged: PR has been merged but still blocks release until someone checks whether it has all the release criteria in Ansible 2.9 May 6, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca bcoca approved these changes

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
Ansible 2.9
Merged: PR has been merged but still ...
Milestone
No milestone
3 participants
@sivel @ansibot @bcoca