-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't pollute include_variables #54687
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
WIP
This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
affects_2.8
This issue/PR affects Ansible v2.8
bug
This issue/PR relates to a bug.
needs_triage
Needs a first human triage before being processed.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
labels
Apr 1, 2019
This comment has been minimized.
This comment has been minimized.
ansibot
added
ci_verified
Changes made in this PR are causing tests to fail.
support:community
This issue/PR relates to code supported by the Ansible community.
and removed
ci_verified
Changes made in this PR are causing tests to fail.
labels
Apr 1, 2019
sivel
changed the title
[WIP] Don't pollute include_variables
Don't pollute include_variables
Apr 8, 2019
sivel
force-pushed
the
no-include-task-args-2
branch
from
April 8, 2019 17:53
b2be406
to
8560b3d
Compare
ansibot
added
core_review
In order to be merged, this PR must follow the core review workflow.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
and removed
WIP
This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
core_review
In order to be merged, this PR must follow the core review workflow.
labels
Apr 8, 2019
ansibot
added
core_review
In order to be merged, this PR must follow the core review workflow.
and removed
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
labels
Apr 9, 2019
bcoca
approved these changes
Apr 9, 2019
bcoca
added this to Merged: PR has been merged but still blocks release until someone checks whether it has all the release criteria
in Ansible 2.9
May 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.8
This issue/PR affects Ansible v2.8
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
support:community
This issue/PR relates to code supported by the Ansible community.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Don't pollute
include_variables
which are in reality task argsFixes #51667. Fixes #54618.
ISSUE TYPE
COMPONENT NAME
lib/ansible/playbook/included_file.py
ADDITIONAL INFORMATION