Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmware_host_config_manager: avoid failure if no change #55115

Merged
merged 1 commit into from
Apr 11, 2019
Merged

vmware_host_config_manager: avoid failure if no change #55115

merged 1 commit into from
Apr 11, 2019

Conversation

goneri
Copy link
Contributor

@goneri goneri commented Apr 10, 2019

SUMMARY

If nothing was changed, the module was raising the following error
because the message variable was not defined:

line 192, in set_host_configuration_facts
UnboundLocalError: local variable 'message' referenced before assignment
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vmware_host_config_manager

@goneri
vmware_host_config_manager: avoid failure if no change
89d010f 
If nothing was changed, the module was raising the following error
because the `message` variable was not defined:

```
line 192, in set_host_configuration_facts
UnboundLocalError: local variable 'message' referenced before assignment
```
@ansibot
Copy link
Contributor

ansibot commented Apr 10, 2019

cc @Akasurde @Tomorrow9 @ckotte @dav1x @lparkes @warthog9
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Apr 10, 2019

@goneri, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Apr 10, 2019
@goneri goneri mentioned this pull request Apr 10, 2019
Closed
@Akasurde Akasurde self-assigned this Apr 11, 2019
@Akasurde Akasurde merged commit 754dfc5 into ansible:devel Apr 11, 2019
@mkrizek mkrizek removed needs_triage Needs a first human triage before being processed. labels Apr 11, 2019
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Akasurde Akasurde

Labels
affects_2.8 This issue/PR affects Ansible v2.8 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@goneri @ansibot @Akasurde @mkrizek