fix nxos_vlan mode idempotence bug #55144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.8
trishnaguha
force-pushed
the
nxos_vlan_mode_idempotence
branch
2 times, most recently
from
269ebce
to
2c0e33c
Compare
ansibot
added
core_review
trishnaguha
removed
the
needs_triage
ansibot
added
the
stale_ci
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
trishnaguha
force-pushed
the
nxos_vlan_mode_idempotence
branch
from
2c0e33c
to
9b221db
Compare
ansibot
added
needs_revision
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
trishnaguha
force-pushed
the
nxos_vlan_mode_idempotence
branch
from
2453bc9
to
6126487
Compare
ansibot
added
core_review
trishnaguha
added a commit
to trishnaguha/ansible
that referenced
this pull request
May 8, 2019
* fix nxos_vlan mode idempotence bug Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * Fix CI failure Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 57e0567)
abadger
pushed a commit
that referenced
this pull request
May 21, 2019
* nxos_vlan: vlan names containing regex ctl chars should be escaped (#55463) The `nxos_vlan` module may raise with regex error `sre_constants.error: multiple repeat` in the non_structured codepath if the device has existing vlan names with certain regex control characters; e.g. ``` VLAN Name Status Ports ---- -------------------------------- --------- ------------------------------- 1 default active Eth1/3 14 my-vlan-name-is-*** active ``` (cherry picked from commit de8ce08) * fix nxos_vlan mode idempotence bug (#55144) * fix nxos_vlan mode idempotence bug Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * Fix CI failure Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 57e0567) * nxos_vlan fix 2.8 backport Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
chrisvanheuveln
added a commit
to chrisvanheuveln/ansible
that referenced
this pull request
May 31, 2019
Symptoms/Analysis: - `nxos_vlan` `purge: true` would fail when `purge` was trying to delete all unspecified vlans, including vlan 1. - `nxos` devices do not allow removing vlan 1 and raise a cli exception error - Previous fix ansible#55144 caused a side effect when `purge` was used: vlan changes specified by `aggregate` were ignored; e.g. - vlan 4 is not present; playbook specifies `aggregate: { vlan: 4 }, purge: true` - results in proper purging but vlan 4 is not created Solutions: - ignore vlan 1 when purging - remove the `not purge` check from state present logic Added additional unit tests and integration tests. Tested against all regression platforms.
StephenSorriaux
pushed a commit
to StephenSorriaux/ansible
that referenced
this pull request
Jun 4, 2019
…7229) * nxos_vlan: fix broken purge behavior (issue ansible#57101) Symptoms/Analysis: - `nxos_vlan` `purge: true` would fail when `purge` was trying to delete all unspecified vlans, including vlan 1. - `nxos` devices do not allow removing vlan 1 and raise a cli exception error - Previous fix ansible#55144 caused a side effect when `purge` was used: vlan changes specified by `aggregate` were ignored; e.g. - vlan 4 is not present; playbook specifies `aggregate: { vlan: 4 }, purge: true` - results in proper purging but vlan 4 is not created Solutions: - ignore vlan 1 when purging - remove the `not purge` check from state present logic Added additional unit tests and integration tests. Tested against all regression platforms. * PEP fixes * Add agg_show_vlan_brief.txt fixture * Add warning for removing vlan 1 * change method name check
trishnaguha
pushed a commit
to trishnaguha/ansible
that referenced
this pull request
Jun 6, 2019
…7229) * nxos_vlan: fix broken purge behavior (issue ansible#57101) Symptoms/Analysis: - `nxos_vlan` `purge: true` would fail when `purge` was trying to delete all unspecified vlans, including vlan 1. - `nxos` devices do not allow removing vlan 1 and raise a cli exception error - Previous fix ansible#55144 caused a side effect when `purge` was used: vlan changes specified by `aggregate` were ignored; e.g. - vlan 4 is not present; playbook specifies `aggregate: { vlan: 4 }, purge: true` - results in proper purging but vlan 4 is not created Solutions: - ignore vlan 1 when purging - remove the `not purge` check from state present logic Added additional unit tests and integration tests. Tested against all regression platforms. * PEP fixes * Add agg_show_vlan_brief.txt fixture * Add warning for removing vlan 1 * change method name check (cherry picked from commit 6bb13bb)
abadger
pushed a commit
that referenced
this pull request
Jun 12, 2019
* nxos_vlan: fix broken purge behavior (issue #57101) (#57229) * nxos_vlan: fix broken purge behavior (issue #57101) Symptoms/Analysis: - `nxos_vlan` `purge: true` would fail when `purge` was trying to delete all unspecified vlans, including vlan 1. - `nxos` devices do not allow removing vlan 1 and raise a cli exception error - Previous fix #55144 caused a side effect when `purge` was used: vlan changes specified by `aggregate` were ignored; e.g. - vlan 4 is not present; playbook specifies `aggregate: { vlan: 4 }, purge: true` - results in proper purging but vlan 4 is not created Solutions: - ignore vlan 1 when purging - remove the `not purge` check from state present logic Added additional unit tests and integration tests. Tested against all regression platforms. * PEP fixes * Add agg_show_vlan_brief.txt fixture * Add warning for removing vlan 1 * change method name check (cherry picked from commit 6bb13bb) * changelog Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
bcoca
pushed a commit
to bcoca/ansible
that referenced
this pull request
Feb 21, 2020
…7229) * nxos_vlan: fix broken purge behavior (issue ansible#57101) Symptoms/Analysis: - `nxos_vlan` `purge: true` would fail when `purge` was trying to delete all unspecified vlans, including vlan 1. - `nxos` devices do not allow removing vlan 1 and raise a cli exception error - Previous fix ansible#55144 caused a side effect when `purge` was used: vlan changes specified by `aggregate` were ignored; e.g. - vlan 4 is not present; playbook specifies `aggregate: { vlan: 4 }, purge: true` - results in proper purging but vlan 4 is not created Solutions: - ignore vlan 1 when purging - remove the `not purge` check from state present logic Added additional unit tests and integration tests. Tested against all regression platforms. * PEP fixes * Add agg_show_vlan_brief.txt fixture * Add warning for removing vlan 1 * change method name check
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Trishna Guha trishnaguha17@gmail.com
SUMMARY
fixes #53887
ISSUE TYPE
COMPONENT NAME
modules/network/nxos/nxos_vlan.py