nxos_vlan: vlan names containing regex ctl chars should be escaped #55463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `nxos_vlan` module may raise with regex error `sre_constants.error: multiple repeat` in the non_structured codepath if the device has existing vlan names with certain regex control characters; e.g. ``` VLAN Name Status Ports ---- -------------------------------- --------- ------------------------------- 1 default active Eth1/3 14 my-vlan-name-is-*** active ```
ansibot
added
affects_2.9
ansibot
removed
the
needs_triage
|
Please cherry-pick to stable2.8 |
ansibot
added
the
stale_ci
trishnaguha
approved these changes
May 2, 2019
trishnaguha
pushed a commit
to trishnaguha/ansible
that referenced
this pull request
May 8, 2019
…nsible#55463) The `nxos_vlan` module may raise with regex error `sre_constants.error: multiple repeat` in the non_structured codepath if the device has existing vlan names with certain regex control characters; e.g. ``` VLAN Name Status Ports ---- -------------------------------- --------- ------------------------------- 1 default active Eth1/3 14 my-vlan-name-is-*** active ``` (cherry picked from commit de8ce08)
abadger
pushed a commit
that referenced
this pull request
May 21, 2019
* nxos_vlan: vlan names containing regex ctl chars should be escaped (#55463) The `nxos_vlan` module may raise with regex error `sre_constants.error: multiple repeat` in the non_structured codepath if the device has existing vlan names with certain regex control characters; e.g. ``` VLAN Name Status Ports ---- -------------------------------- --------- ------------------------------- 1 default active Eth1/3 14 my-vlan-name-is-*** active ``` (cherry picked from commit de8ce08) * fix nxos_vlan mode idempotence bug (#55144) * fix nxos_vlan mode idempotence bug Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> * Fix CI failure Signed-off-by: Trishna Guha <trishnaguha17@gmail.com> (cherry picked from commit 57e0567) * nxos_vlan fix 2.8 backport Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The
nxos_vlanmodule may raise with regex errorsre_constants.error: multiple repeatin the non_structured codepath if the device has existing vlan names with certain regex control characters; e.g. trailing asterisks:The problem only occurs in the non_structured output codepath.
ISSUE TYPE
COMPONENT NAME
modules/network/nxos/nxos_vlan.py