Allow botocore configuration for aws modules

[s-hertel]

SUMMARY

WIP while still looking at a possible solution for boto modules.

This PR allows UserAgent to be set for boto modules and allows general configuration for boto3 modules. Many boto configurations can be set by a boto config file like connection timeout and proxy settings. UserAgent is not able to be configured in that way. In boto3 most of those options have been removed and are only modifiable via code. This addresses both problems.

Tested with CloudTrail.

Fix #55182

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

AWS modules

Example use:

    - name: create bucket
      aws_s3:
        aws_config:
          user_agent: "{{ custom_user_agent }}"
        bucket: "{{ bucket }}"
        region: us-east-1
        mode: create

[tremble]

Looking to close out some of the old PRs before the split happens.

The change looks good to me, any reason not ro move this one forward?

[tremble]

Where's the config argument come from?

[s-hertel]

boto3_conn takes **params, so modules have been able to set custom configurations by doing

boto_core_config = botocore.config.Config(retries={'mode': 'adaptive', 'max_attempts': 10})
connection = boto3_conn(module, conn_type='client', resource=resource, region=region, endpoint=ec2_url, config=boto_core_config, **aws_connect_params)

The old boto config file actually supported a decent amount of customization for different services, whereas botocore/boto3 do not in ~/.aws/config. It makes sense that a module would want to define a resilient default config for the particular service. I'm not sure off the top of my head if there are still things in our codebase using it (though there have been, and easily could be 3rd party things). I don't think it's a super common use case, but the prospect of breaking something in module_utils/ec2 gives me figurative hives.

[s-hertel]

@tremble I mostly paused on it due to caution and lack of enough reviews. I'll add a changelog too.

[s-hertel]

I added ci_complete to the last commit to be on the safe side. I'll merge when they are passing.

[s-hertel]

Thanks @jillr and @tremble for reviewing!