Fix loading namespaced doc_fragments from collections #55249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
WIP
flowerysong
force-pushed
the
coll_doc_fragments
branch
2 times, most recently
from
ceab4a4
to
a54c3f9
Compare
flowerysong
changed the title
ansibot
added
core_review
flowerysong
changed the title
|
cc @nitzmahone |
jillr
removed
the
needs_triage
ansibot
added
the
stale_ci
The syntax for specifying a different fragment name was already using '.' as a separator, so the code needed to be tweaked to avoid choking on names like `testns.testcoll.fragname` and `testns.testcoll.fragname.altvar`. `get_plugin_class()` returns 'docfragment' for the fragment loader; mangling `subdir` provides consistent alignment with the normal plugin directory names and avoids needing special handling of plugin types with 'module' in the name.
flowerysong
force-pushed
the
coll_doc_fragments
branch
from
a54c3f9
to
a33e2bd
Compare
ansibot
removed
the
stale_ci
nitzmahone
requested changes
May 2, 2019
nitzmahone
approved these changes
May 2, 2019
|
rebuild_merge |
ansibot
added
shipit
ansibot
added
shipit
flowerysong
added a commit
to flowerysong/ansible
that referenced
this pull request
May 3, 2019
* Fix loading namespaced doc_fragments The syntax for specifying a different fragment name was already using '.' as a separator, so the code needed to be tweaked to avoid choking on names like `testns.testcoll.fragname` and `testns.testcoll.fragname.altvar`. `get_plugin_class()` returns 'docfragment' for the fragment loader; mangling `subdir` provides consistent alignment with the normal plugin directory names and avoids needing special handling of plugin types with 'module' in the name. * Add changelog entry (cherry picked from commit 2ef8b29)
abadger
pushed a commit
that referenced
this pull request
May 20, 2019
* Fix loading namespaced doc_fragments The syntax for specifying a different fragment name was already using '.' as a separator, so the code needed to be tweaked to avoid choking on names like `testns.testcoll.fragname` and `testns.testcoll.fragname.altvar`. `get_plugin_class()` returns 'docfragment' for the fragment loader; mangling `subdir` provides consistent alignment with the normal plugin directory names and avoids needing special handling of plugin types with 'module' in the name. * Add changelog entry (cherry picked from commit 2ef8b29)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The syntax for specifying a different fragment name was already using '.' as a separator, so the code needed to be tweaked to avoid choking on names like
testns.testcoll.fragnameandtestns.testcoll.fragname.altvar.get_plugin_class()returns 'docfragment' for the fragment loader; manglingsubdirprovides consistent alignment with the normal plugin directory names and avoids any need for special handling of plugin types with 'module' in the name.ISSUE TYPE
COMPONENT NAME
PluginLoader
ADDITIONAL INFORMATION