Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't register tests as filters #55332

Merged
merged 6 commits into from
Apr 16, 2019
Merged

Don't register tests as filters #55332

merged 6 commits into from
Apr 16, 2019

Conversation

sivel
Copy link
Member

@sivel sivel commented Apr 15, 2019

SUMMARY

Don't register tests as filters. Fixes #55319

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
lib/ansible/template/__init__.py
ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 15, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 15, 2019
jamescassell
jamescassell approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@jamescassell jamescassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot
Copy link
Contributor

ansibot commented Apr 16, 2019

cc @mattclay
click here for bot help

@ansibot ansibot added the test This PR relates to tests. label Apr 16, 2019
@ansibot
Copy link
Contributor

ansibot commented Apr 16, 2019

cc @acozine
click here for bot help

@ansibot ansibot added the docs This issue/PR relates to or includes documentation. label Apr 16, 2019
mattclay
mattclay reviewed Apr 16, 2019
View reviewed changes
docs/docsite/rst/dev_guide/testing/sanity/no-tests-as-filters.rst Outdated
@@ -1,10 +0,0 @@
Sanity Tests » no-tests-as-filters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep this file around even though the test has been deleted. That way links from old test runs will continue to work. I've done this for several other tests which no longer exist.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I can do that. I'll just have to indicate it is an orphan

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Apr 16, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 16, 2019
@acozine
Copy link
Contributor

acozine commented Apr 16, 2019

+1 from the docs team

@sivel sivel merged commit 9f83139 into ansible:devel Apr 16, 2019
ndclt pushed a commit to ndclt/ansible that referenced this pull request Jun 13, 2019
@sivel @ndclt
Don't register tests as filters (ansible#55332)
7881ca5 
* Don't register tests as filters. Fixes ansible#55319

* Remove tests for deprecated functionality

* Remove no-tests-as-filters sanity tests

* Remove docs too

* Revert "Remove docs too"

This reverts commit 7daf457.

* Make no-tests-as-filters doc an orphan
@mkrizek mkrizek mentioned this pull request Jun 13, 2019
Merged
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay approved these changes

@jamescassell jamescassell jamescassell approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

template contains deprecated call to be removed in 2.9
5 participants
@sivel @ansibot @acozine @mattclay @jamescassell