psrp - fix test_command rc for win_reboot #55354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @dagwieers @if-meaton @jhawkesworth @nitzmahone |
ansibot
added
affects_2.9
nitzmahone
approved these changes
Apr 16, 2019
nitzmahone
removed
the
needs_triage
jborean93
added a commit
to jborean93/ansible
that referenced
this pull request
Apr 16, 2019
(cherry picked from commit 49655a4)
jborean93
added a commit
to jborean93/ansible
that referenced
this pull request
Apr 16, 2019
(cherry picked from commit 49655a4)
This was referenced Apr 16, 2019
abadger
pushed a commit
that referenced
this pull request
Apr 16, 2019
(cherry picked from commit 49655a4)
abadger
pushed a commit
that referenced
this pull request
Apr 16, 2019
(cherry picked from commit 49655a4)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When using
test_commandwithwin_rebootoverpsrp, the return value was not always returned back to Ansible due to the various escaping. This caused issues as rc of 0 will have win_reboot continue when it shouldn't.This change also unifies another command input to use a PowerShell context like
rawand other command inputs. It finally simplifies the access denied errors by removing the remote shutdown privilege instead of trying to create a temp standard user and allow standard users to connect over WinRM.ISSUE TYPE
COMPONENT NAME
win_reboot