Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle binding:vnic_type as optional #55526

Merged
merged 1 commit into from
May 24, 2019
Merged

Handle binding:vnic_type as optional #55526

merged 1 commit into from
May 24, 2019

Conversation

dominikholler
Copy link
Contributor

SUMMARY

According to the OpenStack Networking API
the attribute binding:vnic_type of a port is optional.
This change enables the os_port module to handle
binding:vnic_type as optional.

Fixes #55524
Fixes #55525

Backport to ansible 2.8 is required.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

os_port

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Apr 18, 2019

cc @Shrews @cloudnull @dagnello @emonty @evrardjp @gtema @juliakreger @mnaser @odyssey4me @rcarrillocruz
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. openstack support:community This issue/PR relates to code supported by the Ansible community. labels Apr 18, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Apr 18, 2019
@opendev-zuul
Copy link

opendev-zuul bot commented Apr 18, 2019

Build succeeded (third-party-check pipeline).

@opendev-zuul
Copy link

opendev-zuul bot commented Apr 18, 2019

Build succeeded (third-party-check pipeline).

@MaxBab
Copy link
Contributor

MaxBab commented Apr 18, 2019

Successfully verified the fix on my environment.

@opendev-zuul
Copy link

opendev-zuul bot commented Apr 18, 2019

Build succeeded (third-party-check pipeline).

@dominikholler
Handle binding:vnic_type as optional
07e2137 
According to the OpenStack Networking API
the attribute binding:vnic_type of a port is optional.
This change enables the os_port module to handle
binding:vnic_type as optional.
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 18, 2019
@opendev-zuul
Copy link

opendev-zuul bot commented Apr 19, 2019

Build succeeded (third-party-check pipeline).

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 27, 2019
@dominikholler
Copy link
Contributor Author

@gundalow can you please have a look?

@mnaser
Copy link
Contributor

mnaser commented May 5, 2019

shipit

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label May 5, 2019
gtema
gtema approved these changes May 9, 2019
View reviewed changes
Copy link
Contributor

@gtema gtema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels May 9, 2019
@mnaser
Copy link
Contributor

mnaser commented May 15, 2019

bot_status

@ansibot
Copy link
Contributor

ansibot commented May 15, 2019

Components

changelogs/fragments/55526-optional_vnic_type.yml
support: community
maintainers:

lib/ansible/modules/cloud/openstack/os_port.py
support: community
maintainers: Shrews cloudnull dagnello emonty evrardjp gtema juliakreger mnaser odyssey4me rcarrillocruz

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 2
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): mnaser gtema
shipit_actors_other: []
automerge: automerge !module file(s) test failed

click here for bot help

mwperina
mwperina approved these changes May 18, 2019
View reviewed changes
Copy link
Contributor

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@dominikholler
Copy link
Contributor Author

@Shrews @cloudnull @dagnello @emonty @evrardjp @gtema @juliakreger @mnaser @odyssey4me @rcarrillocruz
What is missing to get this PR merged?

@mwperina
Copy link
Contributor

John/Toshio, can this be merged? AFAIU is has acks from both OpenStack and RHV teams and RHV team needs this to be backported to 2.8.z

@gundalow @abadger

@abadger
Copy link
Contributor

abadger commented May 22, 2019

I'm no longer working on core code and gundalow is on extended pto. I believe emonty and shrews both have commit privileges.

@jctanner jctanner merged commit bc50a52 into ansible:devel May 24, 2019
dominikholler added a commit to dominikholler/ansible that referenced this pull request May 28, 2019
@dominikholler
Handle binding:vnic_type as optional (ansible#55526)
b399378 
According to the OpenStack Networking API
the attribute binding:vnic_type of a port is optional.
This change enables the os_port module to handle
binding:vnic_type as optional.

(cherry picked from commit bc50a52)
@dominikholler dominikholler mentioned this pull request May 28, 2019
Merged
abadger pushed a commit that referenced this pull request Jun 11, 2019
@dominikholler @abadger
Handle binding:vnic_type as optional (#55526)
86cb408 
According to the OpenStack Networking API
the attribute binding:vnic_type of a port is optional.
This change enables the os_port module to handle
binding:vnic_type as optional.

(cherry picked from commit bc50a52)
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mwperina mwperina mwperina approved these changes

@gtema gtema gtema approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. openstack shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

os_port sends binding:vnic_type=normal without requested os_port exects binding:vnic_type
8 participants
@dominikholler @ansibot @MaxBab @mnaser @mwperina @abadger @gtema @jctanner