Fix notifying handlers by using an exact match #55624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubset if listen is text rather than a list
ansibot
added
affects_2.9
bcoca
reviewed
Apr 22, 2019
s-hertel
changed the title
ansibot
added
the
WIP
s-hertel
removed
the
needs_triage
s-hertel
commented
Apr 23, 2019
s-hertel
changed the title
ansibot
added
support:community
Get validated value early enough
ansibot
added
core_review
ansibot
added
core_review
ansibot
added
the
stale_ci
|
Can this be merged? I think this is a serious bug in ansible 2.8 |
ansibot
removed
the
stale_ci
|
I talked to @bcoca a little more about this one and have come to the conclusion that there is parity with the templating behavior on devel and previous versions of Ansible. I added tests to make sure that remains the same and a couple notes to the documentation to clarify. |
bcoca
approved these changes
Jun 14, 2019
sivel
reviewed
Jun 14, 2019
| @@ -367,14 +367,17 @@ def get_original_host(host_name): | |||
| else: | |||
| return self._inventory.get_host(host_name) | |||
|
|
|||
| def get_handler_templar(handler_task): | |||
There was a problem hiding this comment.
Does this need to be a local function? Several of the others are, because they are using context from _process_pending_results. I don't think this one needs to though, it would just require passing in iterator also.
Not a blocker, just a potential improvement.
There was a problem hiding this comment.
Thanks for the suggestion, fixed that.
ansibot
added
needs_revision
ansibot
added
shipit
s-hertel
added a commit
to s-hertel/ansible
that referenced
this pull request
Jun 27, 2019
* Fix notifying handlers by using an exact match rather than a string subset if listen is text rather than a list * Enforce better type checking for listeners * Share code for validating handler listeners * Add test for handlers without names * Add test for templating in handlers * Add test for include_role * Add a couple notes about 'listen' for handlers * changelog (cherry picked from commit ec1287c)
abadger
pushed a commit
that referenced
this pull request
Jun 28, 2019
* Fix notifying handlers by using an exact match rather than a string subset if listen is text rather than a list * Enforce better type checking for listeners * Share code for validating handler listeners * Add test for handlers without names * Add test for templating in handlers * Add test for include_role * Add a couple notes about 'listen' for handlers * changelog (cherry picked from commit ec1287c)
agowa
pushed a commit
to agowa/ansible-1
that referenced
this pull request
Jun 30, 2019
* Fix notifying handlers by using an exact match rather than a string subset if listen is text rather than a list * Enforce better type checking for listeners * Share code for validating handler listeners * Add test for handlers without names * Add test for templating in handlers * Add test for include_role * Add a couple notes about 'listen' for handlers * changelog * Add a test for handlers without names * Test templating in handlers * changelog * Add some tests for include_role * Add a couple notes about 'listen' for handlers * make more sense * move local function into a class method
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #55575
Introduced in 2a469fd.
'string' in 'stringwithmore' is True, so make sure to wrap listeners in a list to get only exact matches: 'string' in ['stringwithmore'] is False.
ISSUE TYPE