Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_lc: deprecate device_type option #55697

Merged
merged 1 commit into from Apr 24, 2019
Merged

ec2_lc: deprecate device_type option #55697

merged 1 commit into from Apr 24, 2019

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Apr 24, 2019

SUMMARY

Fixes #55308

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/amazon/ec2_lc.py

@mkrizek mkrizek requested a review from s-hertel April 24, 2019 06:53
@ansibot
Copy link
Contributor

ansibot commented Apr 24, 2019

cc @garethr @wilvk
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Apr 24, 2019

@mkrizek, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 aws bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Apr 24, 2019
@s-hertel s-hertel merged commit 43712f8 into ansible:devel Apr 24, 2019
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Apr 24, 2019
@mkrizek mkrizek deleted the issue-55308 branch April 24, 2019 11:29
ndclt pushed a commit to ndclt/ansible that referenced this pull request Jun 13, 2019
@mkrizek @ndclt
ec2_lc: deprecate device_type option (ansible#55697)
f6862bc 
Fixes ansible#55308
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 aws bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ec2_lc contains deprecated call to be removed in 2.9
3 participants
@mkrizek @ansibot @s-hertel