win_iis_webapplication: add authentication parameters

[mhunsber]

SUMMARY

When setting up an application in IIS, you can specify the authentication type as either Application User (pass-through authentication) or specific user with a username and password. This just adds the parameters to support that.

I also added tests since it didn't seem like this module had any integration tests yet.

Added the following parameters to win_iis_webapplication: connect_as, username, password.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

win_iis_webapplication

ADDITIONAL INFORMATION

you can do something like this

win_iis_webapplication:
  state: present
  site: ACME
  name: api
  connect_as: specific_user
  username: acme_user
  password: secret

[ansibot]

cc @dagwieers @henrikwallstrom @if-meaton @jborean93 @jhawkesworth @nitzmahone
click here for bot help

[ShachafGoldstein]

You should add a default option of pass_through

[mhunsber]

If this were a new module, I would make that the default option, but there could be tasks out there using this module where they have changed the authentication to specific user a different way. Making a default value on this option would break that configuration.
Setting a default also wouldn't be consistent with the behavior of application_pool and physical_path, where they are only set if the user passes them as parameters.

[ShachafGoldstein]

you are absolutely right, missed that

[ShachafGoldstein]

Should add a changelog fragment and update the .py file for documentation

[mhunsber]

@ShachafGoldstein I added the changelog fragment. The .py documentation was already updated to show the new options.
I don't really know what happened during the integration test. Looks like it failed on the first task of the tests, which uses the win_iis_website module. Complaining that "Configuration file is not well-formed XML", but the tests don't do anything to change the configuration file before that, unless win_copy somehow changed it when placing a backup configuration in the remote temporary directory. This only happened on the Windows 2019 server, which I think is new since the last CI.

[ShachafGoldstein]

close and open the PR to make it run the tests again

[mhunsber]

Failed on 2012-R2 this time, same error message as before.

[ShachafGoldstein]

Only thing I can think of is that the copy somehow damages the file.
try coping to a different path or skip the copy just to check it maybe?

[mhunsber]

Adding some extra cleanup tasks before restoring the previous IIS configuration seemed to work. After looking closer I realized it was failing on the restore copy because IIS was still using the configuration file. Then the tests were run again in verbose mode, which is where we were seeing the failure in the website module.

[mhunsber]

No idea why Server 2008R2 doesn't like when application_pool is null, I'll just skip it for now and run the tests on 2012 and higher. I'm guessing that it is something to do with the PowerShell version or web administration module version on the host. Maybe someone in the future will decide to make it work on 2008R2.

My guess is that it's either because of the splatting of parameters done here: https://github.com/ansible/ansible/pull/56033/files#diff-bd862e2bbcb44c9c332df7b6cacf6adaR55
or somehow the if($application_pool) is returning true and adding it as a parameter for the splat.

[jborean93]

Thanks for the contribution and adding the tests as well. Apologies for the delay and thanks for sticking with it.