Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_iis_webapplication: add authentication parameters #56033

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@mhunsber
Copy link
Contributor

commented May 2, 2019

SUMMARY

When setting up an application in IIS, you can specify the authentication type as either Application User (pass-through authentication) or specific user with a username and password. This just adds the parameters to support that.

I also added tests since it didn't seem like this module had any integration tests yet.

Added the following parameters to win_iis_webapplication: connect_as, username, password.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

win_iis_webapplication

ADDITIONAL INFORMATION

you can do something like this

win_iis_webapplication:
  state: present
  site: ACME
  name: api
  connect_as: specific_user
  username: acme_user
  password: secret
Micah Hunsberger Micah Hunsberger
@ansibot

This comment has been minimized.

Micah Hunsberger Micah Hunsberger
fixed reference to undefined variable.
added version added to new options.

@ansibot ansibot added core_review and removed needs_revision labels May 2, 2019

@@ -13,6 +13,9 @@ $site = Get-AnsibleParam -obj $params -name "site" -type "str" -failifempty $tru
$state = Get-AnsibleParam -obj $params -name "state" -type "str" -default "present" -validateset "absent","present"
$physical_path = Get-AnsibleParam -obj $params -name "physical_path" -type "str" -aliases "path"
$application_pool = Get-AnsibleParam -obj $params -name "application_pool" -type "str"
$connect_as = Get-AnsibleParam -obj $params -name 'connect_as' -type 'str' -validateset 'specific_user', 'pass_through'

This comment has been minimized.

Copy link
@ShachafGoldstein

ShachafGoldstein May 9, 2019

Contributor

You should add a default option of pass_through

This comment has been minimized.

Copy link
@mhunsber

mhunsber May 13, 2019

Author Contributor

If this were a new module, I would make that the default option, but there could be tasks out there using this module where they have changed the authentication to specific user a different way. Making a default value on this option would break that configuration.
Setting a default also wouldn't be consistent with the behavior of application_pool and physical_path, where they are only set if the user passes them as parameters.

This comment has been minimized.

Copy link
@ShachafGoldstein

ShachafGoldstein May 13, 2019

Contributor

you are absolutely right, missed that

@ShachafGoldstein

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

Should add a changelog fragment and update the .py file for documentation

@ansibot ansibot added the stale_ci label May 13, 2019

@samdoran samdoran removed the needs_triage label May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.