Ensure uri module always returns status even on failure #56240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also return url and update docs for other values to indicate they are only returned on success. Add integration tests
samdoran
commented
May 8, 2019
ansibot
added
WIP
samdoran
changed the title
ansibot
added
needs_revision
jillr
removed
the
needs_triage
ansibot
added
the
stale_ci
This is lines up with with existing code in urls.py
samdoran
force-pushed
the
issue/55897-uri-invalid-cert-status
branch
from
3e0d377
to
863dbf2
Compare
ansibot
added
core_review
sivel
approved these changes
May 22, 2019
samdoran
added a commit
to samdoran/ansible
that referenced
this pull request
May 23, 2019
…nsible#56240) - Also return url and update docs for other values to indicate they are only returned on success. - Add integration tests - Use info variable for common return values - Use -1 as default status rather than None. This is lines up with with existing code in urls.py - Add unit tests to ensure status and url are returned on failure (cherry picked from commit 8f4f375) Co-authored-by: Sam Doran <sdoran@redhat.com>
samdoran
added a commit
to samdoran/ansible
that referenced
this pull request
May 23, 2019
…nsible#56240) - Also return url and update docs for other values to indicate they are only returned on success. - Add integration tests - Use info variable for common return values - Use -1 as default status rather than None. This is lines up with with existing code in urls.py - Add unit tests to ensure status and url are returned on failure. (cherry picked from commit 8f4f375) Co-authored-by: Sam Doran <sdoran@redhat.com>
abadger
pushed a commit
that referenced
this pull request
May 24, 2019
…56240) - Also return url and update docs for other values to indicate they are only returned on success. - Add integration tests - Use info variable for common return values - Use -1 as default status rather than None. This is lines up with with existing code in urls.py - Add unit tests to ensure status and url are returned on failure (cherry picked from commit 8f4f375) Co-authored-by: Sam Doran <sdoran@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #55897
Also return url and update docs for other values to indicate they are only returned on success.
Add integration tests
ISSUE TYPE
COMPONENT NAME
lib/ansible/module_utils/urls.pyADDITIONAL INFORMATION
This seems a bit "leaky" in that I have to change the behavior of
urls.pyto makeuri.pybehave as documented. If this fix seems ok. I will also add unit tests.