Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport/2.8/55695 #56254

Merged
merged 3 commits into from May 21, 2019
Merged

Backport/2.8/55695 #56254

merged 3 commits into from May 21, 2019

Conversation

kustodian
Copy link
Contributor

SUMMARY

Backport of #55695

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

sysctl

@kustodian
sysctl will now return an error if the value is invalid
7281902 
sysctl can fail to set a value even if it returns an exit status 0. More
details: https://bugzilla.redhat.com/show_bug.cgi?id=1264080. Because of
this in case of an invalid value or a read-only file system, sysctl
module would return OK, even though it didn't set anything. To be sure
that sysctl correctly applied the changes we also need to check the
output of stderr.

(cherry picked from commit 0432b7f)
@kustodian
Run sysctl with LANG=C
4fec14d 
Because we are parsing sysctl stderr we need to make sure that errors
are persistent across different system language settings.

(cherry picked from commit a16128f)
@kustodian
Add changelog fragment for sysctl
4652c93 
(cherry picked from commit 3ad9d4d)
@kustodian
Copy link
Contributor Author

@samdoran here is a backport of #55695

@ansibot
Copy link
Contributor

ansibot commented May 9, 2019

cc @Akasurde @davixx
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category labels May 9, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 17, 2019
@abadger abadger merged commit cf611c8 into ansible:stable-2.8 May 21, 2019
@abadger
Copy link
Contributor

abadger commented May 21, 2019

Merged for the 2.8.1 release.

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label May 22, 2019
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kustodian @ansibot @abadger @sivel