[WIP] [2.8] connection/docker: add support for privilege escalation #56277
+54
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in ansible#53385 (and ansible#31759), the docker connection driver did not support privilege escalation. This commit is a shameless cut-and-paste of the privilege escalation support from the `local` connection plugin into the `docker` plugin. Closes: ansible#53385 (cherry picked from commit 61e476b)
ansibot
added
affects_2.8
felixfontein
changed the title
ansibot
added
the
WIP
felixfontein
commented
May 9, 2019
| for key, event in events: | ||
| if key.fileobj == p.stdout: | ||
| chunk = p.stdout.read() | ||
| break |
There was a problem hiding this comment.
I don't think this break should be there (and I guess I missed it in the original PR). It's not in local.py, either. @larsks where does it come from?
There was a problem hiding this comment.
Huh, I haven't the foggiest idea. I didn't do any editing of that content that I recall. Funny that it works. I guess we submit a patch and fix it in the backports? Funny that everything still works. I wish this was all handled in one place...
There was a problem hiding this comment.
I've created #56288 and will include it in this backport once it is merged.
Your stable-2.7 does not have this code included though...
ansibot
added
the
stale_ci
… to local.py (ansible#56288) * Make more similar to local.py * Fix typo. (cherry picked from commit 708bda0)
ansibot
removed
the
stale_ci
|
Merged for 2.8.1 |
sivel
removed
the
needs_triage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Backport of #55816 and #56288 to stable-2.8. Fixes privilege escalation for
dockerconnection plugin if a passphrase is required.CC @larsks
ISSUE TYPE
COMPONENT NAME
lib/ansible/plugins/connection/docker.py