Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PR for fixing IOS static route TC CI failure #56294

Merged
merged 3 commits into from May 21, 2019
Merged

Backport PR for fixing IOS static route TC CI failure #56294

merged 3 commits into from May 21, 2019

Conversation

justjais
Copy link
Contributor

SUMMARY

Cherrypicked from commit (3fdc4ba)
Backport for PR #56292

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ios

ADDITIONAL INFORMATION

@justjais
To fix IOS static route CI failure (ansible#56292)
d81c393 
* ios static failure

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix CI failure

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
(cherry picked from commit 3fdc4ba)
@justjais
adding BP changelog
eedbf57 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais justjais requested a review from mattclay May 10, 2019 08:58
@ansibot
Copy link
Contributor

ansibot commented May 10, 2019

cc @rcarrillocruz
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented May 10, 2019

@justjais, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. labels May 10, 2019
@justjais
adding endline in changelog
24417a9 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@mattclay mattclay removed their request for review May 10, 2019 18:02
@mattclay
Copy link
Member

This won't be included in 2.8.0 RC3 (release in progress currently) or the 2.8.0 GA release.

I'll leave this for @abadger to review for inclusion in 2.8.1.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label May 10, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label May 18, 2019
@abadger abadger merged commit 1e0f140 into ansible:stable-2.8 May 21, 2019
@abadger
Copy link
Contributor

abadger commented May 21, 2019

Merged for the 2.8.1 release

@justjais justjais deleted the backport/2.8/56292 branch June 4, 2019 10:35
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cisco Cisco technologies core_review In order to be merged, this PR must follow the core review workflow. ios Cisco IOS community module This issue/PR relates to a module. networking Network category stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justjais @ansibot @mattclay @abadger