Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify documentation on _info vs. _facts modules #56611

Merged
merged 2 commits into from May 20, 2019
Merged

Clarify documentation on _info vs. _facts modules #56611

merged 2 commits into from May 20, 2019

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Clarifies documentation on _info vs. _facts modules, since that question always comes up again.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs/docsite/rst/dev_guide/developing_modules_best_practices.rst
docs/docsite/rst/dev_guide/developing_modules_checklist.rst

@felixfontein felixfontein requested a review from bcoca May 18, 2019 15:04
@ansibot
Copy link
Contributor

ansibot commented May 18, 2019

cc @acozine @gundalow
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 18, 2019
resmo
resmo approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. labels May 20, 2019
@felixfontein
Copy link
Contributor Author

@acozine suggested to add some more examples on what are facts and what are not facts. @bcoca @resmo can you check whether these make sense (or maybe you have some more/better ideas)?

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed shipit This PR is ready to be merged by Core labels May 20, 2019
@resmo
Copy link
Contributor

resmo commented May 20, 2019

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels May 20, 2019
@acozine
Copy link
Contributor

acozine commented May 20, 2019

Thanks @felixfontein, looks good.

@acozine
Copy link
Contributor

acozine commented May 20, 2019

And thanks @resmo for the review!

@acozine acozine merged commit abca3f1 into ansible:devel May 20, 2019
@felixfontein
Copy link
Contributor Author

@resmo @bcoca @acozine thanks everyone!

@felixfontein felixfontein deleted the clarify-ansible_facts branch May 20, 2019 19:07
felixfontein added a commit to felixfontein/ansible that referenced this pull request May 20, 2019
@felixfontein
Clarify documentation on _info vs. _facts modules (ansible#56611)
5651364 
* Clarify documentation on _info vs. _facts modules.

* Expand with examples for facts and non-facts.

(cherry picked from commit abca3f1)
@felixfontein felixfontein mentioned this pull request May 20, 2019
Merged
acozine pushed a commit that referenced this pull request May 20, 2019
@felixfontein @acozine
Clarify documentation on _info vs. _facts modules (#56611) (#56668)
99f450b 
* Clarify documentation on _info vs. _facts modules.

* Expand with examples for facts and non-facts.

(cherry picked from commit abca3f1)
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

@bcoca bcoca bcoca approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. shipit This PR is ready to be merged by Core support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@felixfontein @ansibot @resmo @acozine @bcoca