Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.8] Clarify documentation on _info vs. _facts modules #56668

Merged
merged 1 commit into from
May 20, 2019
Merged

[2.8] Clarify documentation on _info vs. _facts modules #56668

merged 1 commit into from
May 20, 2019

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Backport of #56611 to stable-2.8: clarify the docs on _info and _facts modules.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs/docsite/rst/dev_guide/developing_modules_best_practices.rst
docs/docsite/rst/dev_guide/developing_modules_checklist.rst

@felixfontein
Clarify documentation on _info vs. _facts modules (ansible#56611)
5651364 
* Clarify documentation on _info vs. _facts modules.

* Expand with examples for facts and non-facts.

(cherry picked from commit abca3f1)
@ansibot
Copy link
Contributor

ansibot commented May 20, 2019

cc @acozine @gundalow
click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 20, 2019
@acozine
Copy link
Contributor

acozine commented May 20, 2019

Thanks @felixfontein

@acozine acozine merged commit 99f450b into ansible:stable-2.8 May 20, 2019
@felixfontein felixfontein deleted the backport/2.8/56611 branch May 20, 2019 20:57
@felixfontein
Copy link
Contributor Author

Thanks for merging @acozine!

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label May 22, 2019
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felixfontein @ansibot @acozine @sivel