Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker_container: fix container creation with networks_cli_compatible=yes #56687

Merged
merged 3 commits into from May 28, 2019
Merged

docker_container: fix container creation with networks_cli_compatible=yes #56687

merged 3 commits into from May 28, 2019

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Fixes #56620.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker_container

@felixfontein felixfontein mentioned this pull request May 21, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented May 21, 2019

cc @DBendit @WojciechowskiPiotr @akshay196 @chouseknecht @cove @danihodovic @dariko @dusdanig @joshuaconner @jwitko @kassiansun @softzilla @tbouvet @zfil
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. docker module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests. labels May 21, 2019
@felixfontein
Copy link
Contributor Author

@DBendit @WojciechowskiPiotr @akshay196 @danihodovic @dariko @jwitko @kassiansun @softzilla @tbouvet it would be great if someone could review this, so we can get this merged!

@felixfontein felixfontein mentioned this pull request May 26, 2019
Merged
Andersson007
Andersson007 approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@felixfontein
Copy link
Contributor Author

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 28, 2019
@ansibot ansibot merged commit d8dcd20 into ansible:devel May 28, 2019
@mkrizek mkrizek removed needs_triage Needs a first human triage before being processed. labels May 28, 2019
@felixfontein felixfontein deleted the docker_container-fix-networks-cli-behavior branch May 28, 2019 18:44
felixfontein added a commit to felixfontein/ansible that referenced this pull request May 28, 2019
@felixfontein
docker_container: fix container creation with networks_cli_compatible…
76d338f 
…=yes (ansible#56687)

* Fix behavior.

* Add changelog.

* Add simple test to prevent ansible#56620.

(cherry picked from commit d8dcd20)
@felixfontein felixfontein mentioned this pull request May 28, 2019
Merged
abadger pushed a commit that referenced this pull request May 29, 2019
@felixfontein @abadger
docker_container: fix container creation with networks_cli_compatible…
0d48ead 
…=yes (#56687)

* Fix behavior.

* Add changelog.

* Add simple test to prevent #56620.

(cherry picked from commit d8dcd20)
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Andersson007 Andersson007 Andersson007 approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. cloud docker module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker_container: networks_cli_compatible: yes playbook failed
4 participants
@felixfontein @ansibot @Andersson007 @mkrizek