docker_container: fix container creation with networks_cli_compatible…

…=yes (ansible#56687) * Fix behavior. * Add changelog. * Add simple test to prevent ansible#56620. (cherry picked from commit d8dcd20)
felixfontein · May 28, 2019 · 76d338f · 76d338f
1 parent 5a1985c
commit 76d338f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/changelogs/fragments/56687-docker_container-networks_cli_compatible.yml b/changelogs/fragments/56687-docker_container-networks_cli_compatible.yml
@@ -0,0 +1,2 @@
+bugfixes:
+- "docker_container - fix network creation when ``networks_cli_compatible`` is enabled."
diff --git a/lib/ansible/modules/cloud/docker/docker_container.py b/lib/ansible/modules/cloud/docker/docker_container.py
@@ -1282,7 +1282,7 @@ def create_parameters(self):
                 if network.get(para):
                     params[para] = network[para]
             network_config = dict()
-            network_config[network['name']] = self.client.create_endpoint_config(params)
+            network_config[network['name']] = self.client.create_endpoint_config(**params)
             result['networking_config'] = self.client.create_networking_config(network_config)
         return result
 

diff --git a/test/integration/targets/docker_container/tasks/tests/network.yml b/test/integration/targets/docker_container/tasks/tests/network.yml
@@ -260,6 +260,9 @@
       state: started
       networks:
       - name: "{{ nname_1 }}"
+        aliases:
+        - alias1
+        - alias2
       - name: "{{ nname_2 }}"
       networks_cli_compatible: yes
     register: networks_1