ansible-test: prefer shlex.quote #56823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.9
mattclay
requested changes
May 23, 2019
mattclay
removed
the
needs_triage
ansibot
added
needs_revision
mattclay
approved these changes
May 23, 2019
ansibot
added
core_review
|
@mattclay which releases do you want me to create backport PRs for this to? |
|
@mkrizek Yes, all the way back to 2.6. Let me know if any of the backports aren't clean. I have some other backports in my queue, so it's possible there may be a conflict. |
mkrizek
added a commit
to mkrizek/ansible
that referenced
this pull request
May 24, 2019
(cherry picked from commit 484c023)
abadger
pushed a commit
that referenced
this pull request
May 26, 2019
(cherry picked from commit 484c023)
mkrizek
added a commit
to mkrizek/ansible
that referenced
this pull request
May 27, 2019
(cherry picked from commit 484c023)
mkrizek
added a commit
to mkrizek/ansible
that referenced
this pull request
May 27, 2019
(cherry picked from commit 484c023)
This was referenced May 27, 2019
|
@mattclay the backports for 2.6 and 2.7 weren't clean, I have resolved the conflicts and created the above PRs. From a first glance, it looks like #54930 and #53510 (possibly others) might have to be backported first so this can be backported cleanly. Let me know if the above PRs need to be rebased with whatever changes you decide to backport. |
abadger
pushed a commit
that referenced
this pull request
May 28, 2019
(cherry picked from commit 484c023)
abadger
pushed a commit
that referenced
this pull request
May 28, 2019
(cherry picked from commit 484c023)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Originally a part of #56785, but moved to a separate PR based on #56785 (comment).
ISSUE TYPE
COMPONENT NAME
ansible-test