Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from pipes.quote #56785

Merged
merged 2 commits into from
May 24, 2019
Merged

Migrate away from pipes.quote #56785

merged 2 commits into from
May 24, 2019

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented May 22, 2019

SUMMARY

Use from ansible.module_utils.six.moves import shlex_quote instead.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

many

@ansibot

This comment has been minimized.

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 ci_verified Changes made in this PR are causing tests to fail. database Database category feature This issue/PR relates to a feature request. module This issue/PR relates to a module. mysql needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. postgresql PostgreSQL community support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. system System category test This PR relates to tests. labels May 22, 2019
@mattclay
Copy link
Member

@mkrizek Thanks for working on this. I'd split out the ansible-test changes into a separate PR so they can be backported independently of the other changes.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label May 22, 2019
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 23, 2019
@ansibot

This comment has been minimized.

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label May 23, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 23, 2019
@mattclay
Copy link
Member

@mkrizek Could you also add pipes.quote to our pylint function blacklist?

blacklist_functions = {
# see https://docs.python.org/2/library/tempfile.html#tempfile.mktemp
'tempfile.mktemp': BlacklistEntry('tempfile.mkstemp'),

You might want to do it as a separate PR after the fixes are merged.

@mkrizek
Copy link
Contributor Author

mkrizek commented May 23, 2019

@mattclay Sure, will do.

@bcoca bcoca merged commit 3b9478a into ansible:devel May 24, 2019
@mkrizek mkrizek deleted the shlex-quote branch May 24, 2019 20:07
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 community_review In order to be merged, this PR must follow the community review workflow. database Database category feature This issue/PR relates to a feature request. module This issue/PR relates to a module. mysql postgresql PostgreSQL community support:community This issue/PR relates to code supported by the Ansible community. system System category test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants