Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: add facts about tags in vmware_cluster_facts #56848

Merged
merged 1 commit into from
Jul 24, 2019
Merged

VMware: add facts about tags in vmware_cluster_facts #56848

merged 1 commit into from
Jul 24, 2019

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented May 23, 2019 •
edited

SUMMARY

Fixes: #46458

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

changelogs/fragments/46458-vmware_cluster_facts-show_tag.yml
lib/ansible/modules/cloud/vmware/vmware_cluster_facts.py
test/integration/targets/prepare_vmware_tests/tasks/init_real_lab.yml
test/integration/targets/prepare_vmware_tests/tasks/setup_category.yml
test/integration/targets/prepare_vmware_tests/tasks/setup_tag.yml
test/integration/targets/prepare_vmware_tests/vars/real_lab.yml
test/integration/targets/vmware_cluster_facts/tasks/main.yml

@Akasurde Akasurde mentioned this pull request May 23, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented May 23, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_cluster_facts.py:108:19: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_cluster_facts.py:108:19: error RETURN: syntax error: expected ',' or '}', but got ':'

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented May 23, 2019

cc @Tomorrow9 @dav1x @goneri @lparkes @warthog9
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 ci_verified Changes made in this PR are causing tests to fail. cloud feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels May 23, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label May 23, 2019
@Akasurde Akasurde force-pushed the i46458 branch 3 times, most recently from 5eeaa14 to 1440606 Compare May 24, 2019 07:59
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed ci_verified Changes made in this PR are causing tests to fail. labels May 24, 2019
@ansibot ansibot removed the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label May 24, 2019
@ansibot
Copy link
Contributor

ansibot commented Jun 1, 2019

cc @pgbidkar
click here for bot help

@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Jun 1, 2019
@Akasurde Akasurde requested a review from goneri June 3, 2019 03:14
@ansibot ansibot removed the stale_review Updates were made after the last review and the last review is more than 7 days old. label Jun 27, 2019
@ansibot ansibot added the stale_review Updates were made after the last review and the last review is more than 7 days old. label Jul 5, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 16, 2019
@Akasurde
Copy link
Member Author

@goneri Could you please review this ? Thanks.

@ansibot ansibot added has_issue and removed stale_review Updates were made after the last review and the last review is more than 7 days old. labels Jul 24, 2019
@Akasurde
VMware: add facts about tags in vmware_cluster_facts
b62fb21 
Fixes: ansible#46458

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde merged commit 401e70c into ansible:devel Jul 24, 2019
@Akasurde Akasurde deleted the i46458 branch July 24, 2019 10:15
@ansible ansible locked and limited conversation to collaborators Aug 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goneri goneri goneri requested changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 cloud feature This issue/PR relates to a feature request. has_issue module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VMware: Return any Tags Assigned to Cluster as value in returned dict
3 participants
@Akasurde @ansibot @goneri