Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker conncetion plugin: accept 'dev' as 'newest version' #56947

Merged
merged 3 commits into from May 26, 2019
Merged

docker conncetion plugin: accept 'dev' as 'newest version' #56947

merged 3 commits into from May 26, 2019

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Some docker/moby packages seem to forget to set a valid version number and end up with dev instead. This patch prints a warning when encountering this and treats dev as "newest version". Fixes #56946, fixes #43639.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/plugins/connection/docker.py

@felixfontein felixfontein mentioned this pull request May 25, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented May 25, 2019

cc @DBendit @WojciechowskiPiotr @akshay196 @danihodovic @dariko @jwitko @kassiansun @tbouvet
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. docker needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels May 25, 2019
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels May 25, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 25, 2019
resmo
resmo approved these changes May 25, 2019
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels May 25, 2019
@felixfontein felixfontein merged commit 2f523ad into ansible:devel May 26, 2019
@felixfontein felixfontein deleted the docker-connection-version-check branch May 26, 2019 12:15
@felixfontein
Copy link
Contributor Author

@resmo thanks for reviewing!

felixfontein added a commit to felixfontein/ansible that referenced this pull request May 26, 2019
@felixfontein
docker conncetion plugin: accept 'dev' as 'newest version' (ansible#5…
0230691 
…6947)

* Accept 'dev' as 'newest version'.

* Add changelog.

* Fix YAML.

(cherry picked from commit 2f523ad)
felixfontein added a commit to felixfontein/ansible that referenced this pull request May 26, 2019
@felixfontein
docker conncetion plugin: accept 'dev' as 'newest version' (ansible#5…
7f6b792 
…6947)

* Accept 'dev' as 'newest version'.

* Add changelog.

* Fix YAML.

(cherry picked from commit 2f523ad)
@felixfontein felixfontein mentioned this pull request May 26, 2019
Merged
@felixfontein
Copy link
Contributor Author

@resmo thanks for reviewing!

@felixfontein
Copy link
Contributor Author

If you're (or anyone else!) is interested in reviewing some more docker bugfixes: #56687, #56610, #56940

abadger pushed a commit that referenced this pull request May 28, 2019
@felixfontein @abadger
docker conncetion plugin: accept 'dev' as 'newest version' (#56947)
4388886 
* Accept 'dev' as 'newest version'.

* Add changelog.

* Fix YAML.

(cherry picked from commit 2f523ad)
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud docker shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The docker connection plugin fails at version checking Docker version check error
3 participants
@felixfontein @ansibot @resmo