[2.8] [docker_network] Fix idempotency when using aux_addresses in ipam_config #56972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fig (ansible#56901) * [docker_network] Fix idempotency when using aux_addresses in ipam_config Mismatch between keys returned by Docker API (AuxilliaryAddresses) vs expected by Ansible module (aux_addresses) resulted in tasks always have status 'changed'. The existing code normalizing one set of keys to another missed this special case where converting CamelCase to lowercase is not sufficent. Please see https://github.com/moby/moby/blob/master/api/types/network/network.go for reference. * Correct keywords formatting in changelog file Co-Authored-By: Felix Fontein <felix@fontein.de> (cherry picked from commit 37df89b)
ansibot
added
affects_2.8
…e#56975) Integration tests for pull request ansible#56901 which fixes found issues with idempotence. (cherry picked from commit 6a50c6a)
|
I also included the extended tests from #56975. |
abadger
reviewed
May 28, 2019
| :type key: str | ||
| :return Ansible module key | ||
| :rtype str | ||
| """ |
There was a problem hiding this comment.
Just a note, we use sphinx's format for documenting parameters.
|
Merged or the 2.8.1 release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Backport of #56901 to stable-2.8. Fixes idempotency for
aux_addresses.ISSUE TYPE
COMPONENT NAME
docker_network