Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.8] [docker_network] Fix idempotency when using aux_addresses in ipam_config #56972

Merged
merged 2 commits into from
May 28, 2019

Commits on May 26, 2019

  1. [docker_network] Fix idempotency when using aux_addresses in ipam_con…

    …fig (ansible#56901)
    
    * [docker_network] Fix idempotency when using aux_addresses in ipam_config
    
    Mismatch between keys returned by Docker API (AuxilliaryAddresses) vs
    expected by Ansible module (aux_addresses) resulted in tasks always
    have status 'changed'. The existing code normalizing one set of
    keys to another missed this special case where converting
    CamelCase to lowercase is not sufficent.
    
    Please see
    https://github.com/moby/moby/blob/master/api/types/network/network.go
    for reference.
    
    * Correct keywords formatting in changelog file
    
    Co-Authored-By: Felix Fontein <felix@fontein.de>
    (cherry picked from commit 37df89b)
    SirFerdek authored and felixfontein committed May 26, 2019
    Configuration menu
    Copy the full SHA
    6942c06 View commit details
    Browse the repository at this point in the history
  2. docker_network: Integration tests for IPAM config idempotence (ansibl…

    …e#56975)
    
    Integration tests for pull request ansible#56901 which fixes found issues with idempotence.
    
    (cherry picked from commit 6a50c6a)
    SirFerdek authored and felixfontein committed May 26, 2019
    Configuration menu
    Copy the full SHA
    6db3b81 View commit details
    Browse the repository at this point in the history