Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix junos_facts test #57065

Merged
merged 1 commit into from
May 29, 2019
Merged

Fix junos_facts test #57065

merged 1 commit into from
May 29, 2019

Conversation

danielmellado
Copy link
Contributor

SUMMARY

Fixes an issue with the junos_facts testing

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

junos_facts

ADDITIONAL INFORMATION

The test expected a fixed string in order to assert it where it had a random
order. This change makes it so the msg is sorted out.

-      - "result.msg == 'Subset must be one of [hardware, default, ofacts, config, interfaces], got test'"
+      - "result.msg == 'Subset must be one of [config, default, hardware, interfaces, ofacts], got test'"

@danielmellado
Fix junos_facts test
b705dd6 
This commit fixes a non-passing junos_facts integration test, as it was
using a non-ordered frozenset to assert its result.
@pabelanger
Copy link
Contributor

recheck

@ansibot
Copy link
Contributor

ansibot commented May 28, 2019

cc @Qalthos @ganeshrn
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. networking Network category small_patch support:network This issue/PR relates to code supported by the Ansible Network Team. labels May 28, 2019
pabelanger
pabelanger approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@pabelanger pabelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ansible-zuul
Copy link

ansible-zuul bot commented May 28, 2019

Build succeeded (third-party-check pipeline).

@pabelanger
Copy link
Contributor

/retest

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 28, 2019
@pabelanger pabelanger merged commit 0ada6b8 into ansible:devel May 29, 2019
danielmellado added a commit to danielmellado/ansible that referenced this pull request May 30, 2019
@danielmellado
Fix junos_facts test (ansible#57065)
b1701a3 
This commit fixes a non-passing junos_facts integration test, as it was
using a non-ordered frozenset to assert its result.

(cherry picked from commit 0ada6b8)
abadger pushed a commit that referenced this pull request May 30, 2019
@danielmellado @abadger
Fix junos_facts test (#57065)
e826eca 
This commit fixes a non-passing junos_facts integration test, as it was
using a non-ordered frozenset to assert its result.

(cherry picked from commit 0ada6b8)
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qalthos Qalthos Qalthos approved these changes

@pabelanger pabelanger pabelanger approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category small_patch support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danielmellado @pabelanger @ansibot @Qalthos