Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix junos_facts test #57065

Merged
merged 1 commit into from
May 29, 2019
Merged

Fix junos_facts test #57065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/ansible/modules/network/junos/junos_facts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,8 @@ def main():

if subset not in VALID_SUBSETS:
module.fail_json(msg='Subset must be one of [%s], got %s' %
(', '.join(VALID_SUBSETS), subset))
(', '.join(sorted([subset for subset in
VALID_SUBSETS])), subset))

if exclude:
exclude_subsets.add(subset)
Expand Down
2 changes: 1 addition & 1 deletion test/integration/targets/junos_facts/tests/netconf/facts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
- assert:
that:
- "result.failed == true"
- "result.msg == 'Subset must be one of [hardware, default, ofacts, config, interfaces], got test'"
- "result.msg == 'Subset must be one of [config, default, hardware, interfaces, ofacts], got test'"

- name: Collect config facts from device in set format
junos_facts:
Expand Down