Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.8] docker_image: fix compatibility bugs #57085

Merged
merged 3 commits into from
Jun 3, 2019
Merged

[2.8] docker_image: fix compatibility bugs #57085

merged 3 commits into from
Jun 3, 2019

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Backport of #56610 and #56940 to stable-2.8.

Will be joined by some tests before [WIP] will go away.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker_image

@felixfontein
docker_image: fix default handling of old docker-build options nocach…
7a9cc73 
…e and rm (ansible#56610)

* Fix usage of nocache parameter.

* Fix defaults.

* Add changelog.

(cherry picked from commit 56e2d48)
@felixfontein
docker_image: fix module failing when build option is used without sp…
539032c 
…ecifying path (ansible#56940)

* Fix module failing when build option is used without specifying path.

* Add changelog.

(cherry picked from commit 86928a5)
@ansibot
Copy link
Contributor

ansibot commented May 28, 2019

cc @DBendit @WojciechowskiPiotr @akshay196 @chouseknecht @danihodovic @dariko @jwitko @kassiansun @softzilla @tbouvet
click here for bot help

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud docker module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels May 28, 2019
@felixfontein
Copy link
Contributor Author

Tests are WIP in #57090.

@felixfontein felixfontein mentioned this pull request Jun 1, 2019
Merged
@ansibot ansibot added the test This PR relates to tests. label Jun 1, 2019
@felixfontein felixfontein changed the title [WIP] [2.8] docker_image: fix compatibility bugs [2.8] docker_image: fix compatibility bugs Jun 1, 2019
@felixfontein
Copy link
Contributor Author

Includes backported tests (#57090), so it's now ready.

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Jun 1, 2019
@WojciechowskiPiotr
Copy link
Contributor

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Jun 1, 2019
@abadger abadger merged commit 5c88199 into ansible:stable-2.8 Jun 3, 2019
@abadger
Copy link
Contributor

abadger commented Jun 3, 2019

Merged for the 2.8.1 release.

@felixfontein felixfontein deleted the backport/2.8/56610-56940 branch June 3, 2019 18:58
@felixfontein felixfontein mentioned this pull request Jun 12, 2019
Merged
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. cloud docker module This issue/PR relates to a module. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felixfontein @ansibot @WojciechowskiPiotr @abadger