Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vyos interface desc fix28 #57228

Merged
merged 2 commits into from
Jun 3, 2019
Merged

Vyos interface desc fix28 #57228

merged 2 commits into from
Jun 3, 2019

Conversation

rohitthakur2590
Copy link
Contributor

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/network/vyos/vyos_interface.py

ADDITIONAL INFORMATION

@rohitthakur2590
vyos interfacefix and test cases
1e5ce52 
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
(cherry picked from commit be1820d)
@rohitthakur2590
backport 28
ec0c65c 
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
@ansibot
Copy link
Contributor

ansibot commented May 31, 2019

cc @NilashishC @Qalthos @ganeshrn @samdoran
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented May 31, 2019

@rohitthakur2590, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team. labels May 31, 2019
@ansible-zuul
Copy link

ansible-zuul bot commented May 31, 2019

Build succeeded (third-party-check pipeline).

abadger
abadger reviewed Jun 3, 2019
View reviewed changes
lib/ansible/modules/network/vyos/vyos_interface.py
@@ -204,6 +204,8 @@ def map_obj_to_commands(updates):
value = w.get(item)

if value and value != obj_in_have.get(item):
if item == 'description':
value = "\'" + str(value) + "\'"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, str is not safe to use like this if value can contain non-ascii characters. let me know if that's the case and I can help you test that case and fix it.

@abadger abadger merged commit 3ae459b into ansible:stable-2.8 Jun 3, 2019
@abadger
Copy link
Contributor

abadger commented Jun 3, 2019

Merged for the 2.8.1 release.

@mkrizek mkrizek removed needs_triage Needs a first human triage before being processed. labels Jun 5, 2019
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abadger abadger abadger left review comments

Assignees
No one assigned
Labels
affects_2.8 This issue/PR affects Ansible v2.8 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. networking Network category support:community This issue/PR relates to code supported by the Ansible community. support:network This issue/PR relates to code supported by the Ansible Network Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rohitthakur2590 @ansibot @abadger @mkrizek