Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[facts] add hpux fc info, refactor aix and solaris code #57406

Merged
merged 6 commits into from Apr 28, 2021
Merged

[facts] add hpux fc info, refactor aix and solaris code #57406

merged 6 commits into from Apr 28, 2021

Conversation

mator
Copy link
Contributor

@mator mator commented Jun 5, 2019

SUMMARY

Add hp-ux OS support for FC facts gathering. Refactor existing code to add checks for command existence and return code checks.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

Used https://kerneltalks.com/scripts/list-wwn-of-active-fc-in-hpux-server/ as a base for HP-UX patch.
No real hardware testing performed (i don't have access to any) for HPUX.

Refactor existing code for AIX and Solaris adding checks for command existence before further processing and return code checks after command run.

@mator mator changed the title [facts] add hpux fc info, refactor aix and solaris code, adding checks for command exists and return code [facts] add hpux fc info, refactor aix and solaris code Jun 5, 2019
@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 5, 2019
@ansibot
Copy link
Contributor

ansibot commented Jun 5, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

test/units/module_utils/facts/network/test_fc_wwn.py:93:0: dangerous-default-value Dangerous default value [] as argument

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 5, 2019
@mator mator closed this Jun 6, 2019
@mator mator reopened this Jun 6, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 6, 2019
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jun 6, 2019
@bcoca bcoca requested review from bcoca and samdoran June 6, 2019 19:08
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 14, 2019
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 3, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 11, 2019
@relrod relrod self-assigned this Oct 23, 2020
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. pre_azp This PR was last tested before migration to Azure Pipelines. and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 10, 2020
@samdoran
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. pre_azp This PR was last tested before migration to Azure Pipelines. labels Feb 15, 2021
@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Feb 15, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 23, 2021
@ansibot ansibot removed the support:community This issue/PR relates to code supported by the Ansible community. label Mar 3, 2021
@samdoran
Copy link
Contributor

samdoran commented Apr 6, 2021

/rebuild_merge

@samdoran
Copy link
Contributor

samdoran commented Apr 6, 2021

/rebuild

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 6, 2021
@Akasurde
Copy link
Member

/rebuild

@Akasurde Akasurde closed this Apr 28, 2021
@Akasurde Akasurde reopened this Apr 28, 2021
@samdoran samdoran merged commit 04e57d2 into ansible:devel Apr 28, 2021
@mator mator deleted the hpux_fc_info branch April 28, 2021 14:23
maximmasiutin pushed a commit to maximmasiutin/ansible that referenced this pull request Apr 28, 2021
@mator @maximmasiutin
[facts] add hpux fc info, refactor aix and solaris code (ansible#57406)
1ec2c37 
* correctly parse device from string
* check for command presence before running them
* check for command presence and return code for solaris and aix as well
* add changelog
@ansible ansible locked and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samdoran samdoran samdoran approved these changes

@bcoca bcoca Awaiting requested review from bcoca

Assignees

@relrod relrod

Labels
affects_2.9 This issue/PR affects Ansible v2.9 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mator @ansibot @samdoran @Akasurde @relrod @bcoca