Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[facts] add hpux fc info, refactor aix and solaris code #57406

Open
wants to merge 5 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@mator
Copy link
Contributor

commented Jun 5, 2019

SUMMARY

Add hp-ux OS support for FC facts gathering. Refactor existing code to add checks for command existence and return code checks.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

Used https://kerneltalks.com/scripts/list-wwn-of-active-fc-in-hpux-server/ as a base for HP-UX patch.
No real hardware testing performed (i don't have access to any) for HPUX.

Refactor existing code for AIX and Solaris adding checks for command existence before further processing and return code checks after command run.

@mator mator changed the title [facts] add hpux fc info, refactor aix and solaris code, adding checks for command exists and return code [facts] add hpux fc info, refactor aix and solaris code Jun 5, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

test/units/module_utils/facts/network/test_fc_wwn.py:93:0: dangerous-default-value Dangerous default value [] as argument

click here for bot help

@ansibot ansibot added needs_revision and removed core_review labels Jun 5, 2019

@mator mator closed this Jun 6, 2019

@mator mator reopened this Jun 6, 2019

@ansibot ansibot added core_review and removed needs_revision labels Jun 6, 2019

@bcoca bcoca removed the needs_triage label Jun 6, 2019

@bcoca bcoca requested review from bcoca and samdoran Jun 6, 2019

@ansibot ansibot added the stale_ci label Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.