Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set ovirt disk active default #57464

Merged
merged 5 commits into from Jun 12, 2019
Merged

set ovirt disk active default #57464

merged 5 commits into from Jun 12, 2019

Conversation

mnecas
Copy link
Contributor

@mnecas mnecas commented Jun 6, 2019

SUMMARY

set ovirt disk active default value to True

Fixes #57412

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ovirt

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jun 6, 2019

cc @machacekondra @mwperina
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. ovirt oVirt and RHV community owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Jun 6, 2019
machacekondra
machacekondra reviewed Jun 10, 2019
View reviewed changes
lib/ansible/modules/cloud/ovirt/ovirt_disk.py Outdated
@@ -192,6 +192,7 @@
- I(True) if the disk should be activated.
version_added: "2.8"
type: bool
default: True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change the behavior so the True is used only in case the disk is being created. In case it should be updated don't use True, but rather don't do anywhing if user didn't specify activate parameter.

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jun 10, 2019
@ansibot
Copy link
Contributor

ansibot commented Jun 10, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/ovirt/ovirt_disk.py:714:17: E265 block comment should start with '# '

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. small_patch labels Jun 10, 2019
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 10, 2019
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. owner_pr This PR is made by the module's maintainer. labels Jun 11, 2019
mwperina
mwperina reviewed Jun 12, 2019
View reviewed changes
changelogs/fragments/57464-set-ovirt-disk-active-default.yaml Outdated
@@ -0,0 +1,2 @@
bugfixes:
- Fix when creating disk for vm its not activated (https://github.com/ansible/ansible/issues/57412)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it more understandable, for example:
"Fix the issue that disk is not activated after its creation"

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 12, 2019
@machacekondra
Copy link
Contributor

+1

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jun 12, 2019
@machacekondra
Copy link
Contributor

bot_status

@ansibot
Copy link
Contributor

ansibot commented Jun 12, 2019

Components

changelogs/fragments/57464-set-ovirt-disk-active-default.yaml
support: community
maintainers:

lib/ansible/modules/cloud/ovirt/ovirt_disk.py
support: community
maintainers: machacekondra mnecas mwperina

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 2
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): machacekondra mnecas
shipit_actors_other: []
automerge: automerge !module file(s) test failed

click here for bot help

@mkrizek mkrizek merged commit 4052d6d into ansible:devel Jun 12, 2019
@mkrizek mkrizek mentioned this pull request Jun 12, 2019
Closed
mnecas added a commit to mnecas/ansible that referenced this pull request Jun 12, 2019
@mnecas
set ovirt disk active default (ansible#57464)
7475e2d 
* set ovirt disk active default value to True

* disk default activate only when creating

* correct comment syntax

* add changelog

* ovirt disk activate update docs
@mnecas mnecas mentioned this pull request Jun 12, 2019
Merged
pkubica added a commit to pkubica/ovirt-ansible-manageiq that referenced this pull request Jun 17, 2019
@pkubica
Workaround: disk activation for deploying CFME
6d5efa5 
Workaround for issue with disk activation after its creation
described here: ansible/ansible#57464
@pkubica pkubica mentioned this pull request Jun 17, 2019
Merged
machacekondra pushed a commit to oVirt/ovirt-ansible-manageiq that referenced this pull request Jun 17, 2019
@pkubica @machacekondra
Workaround: disk activation for deploying CFME (#85)
5978f66 
Workaround for issue with disk activation after its creation
described here: ansible/ansible#57464
abadger pushed a commit that referenced this pull request Jun 18, 2019
@mnecas @abadger
set ovirt disk active default (#57464) (#57748)
0521b30 
* set ovirt disk active default  (#57464)

* set ovirt disk active default value to True

* disk default activate only when creating

* correct comment syntax

* add changelog

* ovirt disk activate update docs

* Update ovirt_disk.py

* Update ovirt_disk.py
agowa pushed a commit to agowa/ansible-1 that referenced this pull request Jun 30, 2019
@mnecas @agowa
set ovirt disk active default (ansible#57464)
7e43dae 
* set ovirt disk active default value to True

* disk default activate only when creating

* correct comment syntax

* add changelog

* ovirt disk activate update docs
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@machacekondra machacekondra machacekondra left review comments

@mwperina mwperina mwperina left review comments

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. ovirt oVirt and RHV community shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default value for disk activate is set to false
5 participants
@mnecas @ansibot @machacekondra @mwperina @mkrizek