Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing gcp modules to gcp module defaults group #57779

Merged
merged 2 commits into from
Sep 19, 2019
Merged

Add missing gcp modules to gcp module defaults group #57779

merged 2 commits into from
Sep 19, 2019

Conversation

jpmahowald
Copy link
Contributor

@jpmahowald jpmahowald commented Jun 12, 2019 •
edited

SUMMARY

Add missing gcp modules to gcp module defaults group
Fixes #56324

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module_defaults

ADDITIONAL INFORMATION

41 modules were missing from the gcp group. This adds everything matching modules/cloud/google/gcp_*.py

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 12, 2019
@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Jun 12, 2019
@jpmahowald jpmahowald marked this pull request as ready for review June 13, 2019 00:09
@samdoran
Copy link
Contributor

We should add a sanity test to check for modules missing from this file.

@samdoran samdoran added gce and removed needs_triage Needs a first human triage before being processed. labels Jun 13, 2019
@jpmahowald
Copy link
Contributor Author

Any ideas about implementation of a sanity test, how to iterate on modules matching this pattern when they may not be in the group yet?

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 22, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 31, 2019

@jpmahowald Your branch does not contain a shippable.yml file. Please rebase your branch to trigger running of current tests.

click here for bot help

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_repo This PR no longer has an associated branch as it was removed by the submitter. needs_shippable This PR lacks a shippable.yml in its tree. Please rebase your branch to include the latest CI tests. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 31, 2019
@rambleraptor
Copy link
Contributor

Hello! Thanks a lot for adding this. It would be great to have a sanity test that was capable of flagging these additions for us

@gundalow
Copy link
Contributor

@rambleraptor Is this good to merge as-is? Updating sanity test can be done in a follow up PR.

The branch in @jpmahowald fork has been deleted so no further updates can be made.

needs_info

@gundalow gundalow added the pr_day Has been reviewed during a PR review Day label Sep 19, 2019
@ansibot ansibot added the needs_info This issue requires further information. Please answer any outstanding questions. label Sep 19, 2019
@rambleraptor
Copy link
Contributor

yeah, this looks good!

@gundalow gundalow merged commit 4116d26 into ansible:devel Sep 19, 2019
@gundalow
Copy link
Contributor

@jpmahowald Thank you for spotting this
@rambleraptor Thanks for the reviews.

Can chat on IRC about how a sanity test could be added for this.

anas-shami pushed a commit to anas-shami/ansible that referenced this pull request Sep 23, 2019
@jpmahowald @anas-shami
Add missing gcp modules to gcp module defaults group (ansible#57779)
b86b9df 
* Add missing gcp modules to gcp module defaults group

Fixes ansible#56324

* Add changelog fragment for ansible#57779
@ansible ansible locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. gce needs_info This issue requires further information. Please answer any outstanding questions. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_repo This PR no longer has an associated branch as it was removed by the submitter. needs_shippable This PR lacks a shippable.yml in its tree. Please rebase your branch to include the latest CI tests. pr_day Has been reviewed during a PR review Day stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gcp_iam_* and gcp_storage_* modules do not use module defaults for group/gcp
5 participants
@jpmahowald @samdoran @ansibot @rambleraptor @gundalow