Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing gcp modules to gcp module defaults group #57779

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@jpmahowald
Copy link
Contributor

commented Jun 12, 2019

SUMMARY

Add missing gcp modules to gcp module defaults group
Fixes #56324

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module_defaults

ADDITIONAL INFORMATION

41 modules were missing from the gcp group. This adds everything matching modules/cloud/google/gcp_*.py

@jpmahowald jpmahowald marked this pull request as ready for review Jun 13, 2019

@samdoran

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

We should add a sanity test to check for modules missing from this file.

@samdoran samdoran added gce and removed needs_triage labels Jun 13, 2019

@jpmahowald

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2019

Any ideas about implementation of a sanity test, how to iterate on modules matching this pattern when they may not be in the group yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.