Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ce_vxlan_global to fix bugs. #57947

Merged
merged 3 commits into from
Jun 28, 2019
Merged

update ce_vxlan_global to fix bugs. #57947

merged 3 commits into from
Jun 28, 2019

Conversation

yuandongx
Copy link
Contributor

@yuandongx yuandongx commented Jun 17, 2019 •
edited

SUMMARY

update ce_vxlan_global to fix bugs.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/network/cloudengine/ce_vxlan_global.py

ADDITIONAL INFORMATION
  1. line 242 , bd_info is a string array,and it should be 'extend' operation.
  2. line 423, 'if' and 'else' should set a different value. if 'exist', that value is 'enable'.
  3. line 477. To get state of result, if it is changed or not.

@yuandongx yuandongx mentioned this pull request Jun 17, 2019
Closed
@ansibot
Copy link
Contributor

ansibot commented Jun 17, 2019

@xuxiaowei0512, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. labels Jun 17, 2019
@yuandongx yuandongx closed this Jun 21, 2019
@yuandongx yuandongx reopened this Jun 21, 2019
@ansibot
Copy link
Contributor

ansibot commented Jun 21, 2019

cc @QijunPan @TommyLike @edisonxiang @freesky-edward @niuzhenguo @zengchen1024 @zhongjun2
click here for bot help

@ansibot ansibot added owner_pr This PR is made by the module's maintainer. and removed needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) labels Jun 21, 2019
resmo
resmo approved these changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

integration tests for this would be helpful, please add a changelog fragment https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment

@zhongjun2
Copy link
Contributor

bot_status

@zhongjun2
Copy link
Contributor

shipit

@ansibot
Copy link
Contributor

ansibot commented Jun 28, 2019

Components

changelogs/fragments/57947-update-ce_vxlan_global-to-fix-bugs.yml
support: community
maintainers:

lib/ansible/modules/network/cloudengine/ce_vxlan_global.py
support: community
maintainers: QijunPan TommyLike edisonxiang freesky-edward niuzhenguo xuxiaowei0512 zengchen1024 zhongjun2

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 2
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): zhongjun2 xuxiaowei0512
shipit_actors_other: []
automerge: automerge tests passed

click here for bot help

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Jun 28, 2019
@ansibot ansibot merged commit 242f160 into ansible:devel Jun 28, 2019
agowa pushed a commit to agowa/ansible-1 that referenced this pull request Jun 30, 2019
@yuandongx @agowa
update ce_vxlan_global to fix bugs. (ansible#57947)
e8bd62b 
* update to fix bugs.

* add a changelog fragment.

* update a changelog fragment.
abadger pushed a commit that referenced this pull request Jul 9, 2019
@abadger
Backport/2.8/57947 update ce_vxlan_global to fix bugs. (#57947) (#58553)
ead3787 
* update ce_vxlan_global to fix bugs.  (#57947)

* update to fix bugs.

* add a changelog fragment.

* update a changelog fragment.

(cherry picked from commit 242f160)

* Update 57947-update-ce_vxlan_global-to-fix-bugs.yml
@ansible ansible locked and limited conversation to collaborators Aug 5, 2019
@yuandongx yuandongx deleted the dev/update/ce_vxlan_global branch September 26, 2019 06:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@resmo resmo resmo approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. module This issue/PR relates to a module. networking Network category owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yuandongx @ansibot @zhongjun2 @resmo