Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR to fix minor issues with Checkpoint module #58049

Merged
merged 2 commits into from
Jul 16, 2019
Merged

PR to fix minor issues with Checkpoint module #58049

merged 2 commits into from
Jul 16, 2019

Conversation

justjais
Copy link
Contributor

Signed-off-by: Sumit Jaiswal sjaiswal@redhat.com

SUMMARY

PR to fix minor issues with Checkpoint module, making state default option to present and resolving error scenario.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

checkpoint

ADDITIONAL INFORMATION

@justjais
minor checkpoint module fix
8497bf5 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@justjais
Copy link
Contributor Author

cc. @chkp-orso

@ansibot
Copy link
Contributor

ansibot commented Jun 19, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/checkpoint/cp_network.py:0:0: E324 Argument 'state' in argument_spec defines default as ('present') but documentation defines default as (None)

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. networking Network category support:community This issue/PR relates to code supported by the Ansible community. labels Jun 19, 2019
@justjais
state default value set
6c23859 
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 19, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 27, 2019
@maxamillion
Copy link
Contributor

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 16, 2019
@ansibot ansibot merged commit 0bde145 into ansible:devel Jul 16, 2019
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jul 22, 2019
@ansible ansible locked and limited conversation to collaborators Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maxamillion maxamillion maxamillion approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. networking Network category shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justjais @ansibot @maxamillion @sivel