Add exception handling to win_domain_controller #58234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.9
samdoran
removed
the
needs_triage
jborean93
reviewed
Jul 4, 2019
|
Also it would be great if you could add a changelog similar to https://github.com/ansible/ansible/pull/53480/files#diff-0b9ea3a63f047de3086e081e4eb479f2R3 for the module. |
ansibot
added
the
stale_ci
|
closing and reopening to trigger the ci |
ansibot
added
support:community
|
This needs to be rebased in order for tests to run properly. |
samdoran
added
the
ci_verified
ansibot
added
the
needs_rebase
ansibot
added
the
stale_ci
|
The test |
ansibot
added
has_issue
and removed
needs_rebase
ansibot
added
core_review
agowa
force-pushed
the
patch-12
branch
2 times, most recently
from
b2ae13f
to
304af42
Compare
As requested by PR review in ansible#58234 (comment)
ansibot
added
the
stale_ci
jborean93
approved these changes
Aug 16, 2019
|
rebuild_merge |
|
Looks like the bot is having issues, manually rerunning tests to ensure it isn't stale before merging. |
ansibot
added
shipit
|
Feel free to backport this to stable-2.8 if you wish https://docs.ansible.com/ansible/latest/community/development_process.html#backporting-merged-prs. |
agowa
pushed a commit
to agowa/ansible-1
that referenced
this pull request
Aug 19, 2019
* Add exception handling to win_domain_controller * Add changelog * Fix PSUseDeclaredVarsMoreThanAssignments * Remove dns domain cannot be resolved error message As requested by PR review in ansible#58234 (comment)
agowa
pushed a commit
to agowa/ansible-1
that referenced
this pull request
Sep 4, 2019
* Add exception handling to win_domain_controller * Add changelog * Fix PSUseDeclaredVarsMoreThanAssignments * Remove dns domain cannot be resolved error message As requested by PR review in ansible#58234 (comment)
abadger
pushed a commit
that referenced
this pull request
Sep 4, 2019
* Add exception handling to win_domain_controller * Add changelog * Fix PSUseDeclaredVarsMoreThanAssignments * Remove dns domain cannot be resolved error message As requested by PR review in #58234 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add error handling for two exceptions.
ISSUE TYPE
COMPONENT NAME
win_domain_controller
ADDITIONAL INFORMATION
If a user specifies a domain to join that cannot be resolved by dns, the Install-ADDSDomainController command throws an Microsoft.ADRoles.Deployment.Common.Tests.TestFailedException exception.
If the module is either invoked twice without a reboot, or a reboot is pending for another reason the Install-ADDSDomainController command throws an Microsoft.DirectoryServices.Deployment.DCPromoExecutionException exception with Errorcode 15.
I added error handling for both of them, so that a user can handle them from within the playbook.