Bug Fix: Route 53 Health Check behaves incorrectly with > 100 health checks

[mdierolf]

This PR fixes a bug where the Route 53 Health Check would add a new health check instead of updating an existing one when the user has > 100 health checks on their AWS account

SUMMARY

When you attempt to update a health check with route53_health_check, the module first loads a list of all your health checks, looks for a matching health check, and then updates an existing check if found, or creates a new one.

However, when you have more than 100 health checks, AWS requires you to list the health checks 100 at a time and walk through the paginated results, which this module was not doing, causing massive numbers of duplicate health checks to be created, as the module thought that their were no existing health checks which matched

This PR implements pagination for the find_health_check call to fix this bug

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

route53_health_check

[ansibot]

cc @willthames @zimbatm
click here for bot help

[ansibot]

@mdierolf, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

[jillr]

As we discussed in irc there's some limitations around testing for this use case, this module ultimately needs to be updated to boto3. But testing locally I can cleanly create/delete healthchecks with this branch and the code lgtm. Thanks for this fix @mdierolf !