Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

na_ontap_quota was not using vserver #58594

Merged
merged 2 commits into from
Jul 31, 2019
Merged

na_ontap_quota was not using vserver #58594

merged 2 commits into from
Jul 31, 2019

Conversation

carchi8py
Copy link
Contributor

SUMMARY

na_ontap_quota was not using verserver

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • na_ontap_quotas
ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jul 1, 2019

cc @amit0701 @hulquest @lmprice @lonico @ndswartz @schmots1
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. netapp owner_pr This PR is made by the module's maintainer. small_patch storage support:certified This issue/PR relates to certified code. labels Jul 1, 2019
@mattclay mattclay added the ci_verified Changes made in this PR are causing tests to fail. label Jul 1, 2019
@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jul 1, 2019
lonico
lonico reviewed Jul 2, 2019
View reviewed changes
lib/ansible/modules/storage/netapp/na_ontap_quotas.py Outdated
@@ -326,7 +327,7 @@ def apply(self):
elif cd_action == 'delete':
self.quota_entry_delete()
elif modify_quota is not None:
for key in list(modify_quota):
for key in modify_quota:
Copy link
Contributor

@lonico lonico Jul 2, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should not be modified

Though it would have been cleaner to create a new dictionary, since it is only used locally to call self.quota_entry_modify

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 10, 2019
lonico
lonico approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@lonico lonico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed ci_verified Changes made in this PR are causing tests to fail. small_patch stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 11, 2019
@ansibot ansibot added automerge This PR was automatically merged by ansibot. support:community This issue/PR relates to code supported by the Ansible community. and removed support:certified This issue/PR relates to certified code. labels Jul 31, 2019
@ansibot ansibot merged commit dc427ff into ansible:devel Jul 31, 2019
@ansible ansible locked and limited conversation to collaborators Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lonico lonico lonico approved these changes

Assignees

@JohnLieske JohnLieske

Labels
affects_2.9 This issue/PR affects Ansible v2.9 automerge This PR was automatically merged by ansibot. bug This issue/PR relates to a bug. module This issue/PR relates to a module. netapp owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core storage support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@carchi8py @ansibot @lonico @mattclay @JohnLieske