failed to use variable for retries in the loop

[jack1402]

Issue Type:

“Bug Report”

Ansible Version:

1.4.3

Environment:

RHEL 6.5

Summary:

we are trying to use the variable for the value of retries at loop. But always hit an error

Steps To Reproduce:

Run following playbook:

hosts: localhost 
     vars: tries: 5 
tasks:
     - name: test
       debug: msg="looping" 
       register: output 
       until: no 
       retries: "{{ tries | int }}" 
       delay: 1

Expected Results:

retries count is 5

Actual Results:

get following error:

TASK: [test] ******************************************************************
fatal: [localhost] => Traceback (most recent call last):
File "/usr/lib/python2.6/site-packages/ansible/runner/init.py", line 394, in executor
execrc = self.executorinternal(host, new_stdin)
File "/usr/lib/python2.6/site-packages/ansible/runner/init.py", line 485, in executorinternal
return self.executorinternal_inner(host, self.module_name, self.module_args, inject, port, complex_args=complex_args)
File "/usr/lib/python2.6/site-packages/ansible/runner/init.py", line 694, in executorinternal_inner
for x in range(1, retries + 1):
TypeError: cannot concatenate 'str' and 'int' objects

FATAL: all hosts have already failed -- aborting

[rafecolton]

Looks like this is still an issue with 1.8.2?

[evgeny-goldin]

Yes, in 1.8.2

retries: '{{ 5 }}'

produces

  File "/usr/local/lib/python2.7/site-packages/ansible/runner/__init__.py", line 590, in _executor
    exec_rc = self._executor_internal(host, new_stdin)
  File "/usr/local/lib/python2.7/site-packages/ansible/runner/__init__.py", line 818, in _executor_internal
    complex_args=complex_args
  File "/usr/local/lib/python2.7/site-packages/ansible/runner/__init__.py", line 1035, in _executor_internal_inner
    for x in range(1, int(retries) + 1):
ValueError: invalid literal for int() with base 10: '{{ 5 }}'

[srikanthsrs]

In which version is this fixed?

[evgeny-goldin]

I have it working with Ansible 1.8.4.

[semente]

Hey guys, looks like we have a regression on 2.3.0, at least when using on docker_service.scale:

    - name: set up web apps
      docker_service:
        project_src: "/srv/{{ item }}"
        stopped: "{{ instances.get(item).is_disabled | default('false') }}"
        pull: yes
        scale:
          web: "{{ instances.get(item).scale }}"
      with_items: "{{ web_instances }}"

I've tried with and without | int. Any advice? Is it really a regression? On 2.2.0 it used to work.

[kassiansun]

@semente You can ignore the double quotes, like web: {{ instances.get(item).scale }}

[semente]

@kassiansun thanks but that won't work due a syntax error.

Always quote template expression brackets when they start a value

[kassiansun]

@semente Oh, it can be used in jinja2 templates, but you're using this in playbooks.

I submitted a patch to my own repository: https://github.com/kassiansun/ansible/commit/59e38bd4bc383a608b62a6cc6b6c89d201203226, you can hot fix the code in /usr/lib/python2.7/site-packages/ansible/modules/cloud/docker/docker_service.py. If it works, I will submit a MR to this repository.

Many ansible modules are poorly maintained like docker_service

[semente]

Hey @kassiansun, awesome! I didn't work on this project since them but I will test your patch asap and I let you know if it fixed the issue. Thanks!!

By the way, should I open a new Issue or that won't be necessary?

[kassiansun]

@semente Seems a good idea, as this issue is closed long time ago.