Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VMware: New Module for content library CRUD operations #58716

Merged
merged 1 commit into from
Jul 12, 2019
Merged

VMware: New Module for content library CRUD operations #58716

merged 1 commit into from
Jul 12, 2019

Conversation

pgbidkar
Copy link
Contributor

@pgbidkar pgbidkar commented Jul 4, 2019

SUMMARY

New module to create, Update & delete content library.
Content library created with datastore backing

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

VMWare content library

@ansibot
Copy link
Contributor

ansibot commented Jul 4, 2019

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:0:0: missing documentation (or could not parse documentation): invalid syntax (<unknown>, line 6)

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:6:1: SyntaxError:

The test ansible-test sanity --test integration-aliases [explain] failed with 1 error:

test/integration/targets/vmware_content_library/aliases:0:0: missing alias `shippable/posix/group[1-4]` or `unsupported`

The test ansible-test sanity --test line-endings [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:0:0: use "\n" for line endings instead of "\r\n"

click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jul 4, 2019

cc @Akasurde @Tomorrow9 @goneri @lparkes @warthog9
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 cloud module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community labels Jul 4, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 4, 2019

@GBrawl @MikeKlebolt @Tomorrow9 @alongchamps @bedecarroll @CastawayEGR @chrrrles @dav1x @davidmhewitt @garbled1 @GyorgyPeter @imjoseangel @jjahns @kamsz @karstenjakobsen @kryptsi @lrivallain @michaeldeaton @nafpliot-ibm @nerzhul @oboukili @ritzk @rmin @stravassac @sumkincpp @vmwjoseph @warthog9 @woshihaoren

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 4, 2019
@Akasurde Akasurde changed the title New Module for content library CRUD operations VMware: New Module for content library CRUD operations Jul 5, 2019
@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Jul 5, 2019
@Akasurde Akasurde self-assigned this Jul 5, 2019
@Akasurde Akasurde requested review from goneri and jillr July 5, 2019 06:45
Akasurde
Akasurde requested changes Jul 5, 2019
View reviewed changes
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py Outdated Show resolved Hide resolved
lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py Outdated Show resolved Hide resolved
lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py Outdated Show resolved Hide resolved
lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py Outdated Show resolved Hide resolved
lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py Outdated Show resolved Hide resolved
lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py Show resolved Hide resolved
lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py Outdated Show resolved Hide resolved
test/integration/targets/vmware_content_library/aliases Outdated Show resolved Hide resolved
test/integration/targets/vmware_content_library/aliases Outdated Show resolved Hide resolved
lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py Outdated Show resolved Hide resolved
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Jul 5, 2019
@pgbidkar
Copy link
Contributor Author

pgbidkar commented Jul 5, 2019

Thanks @Akasurde for reviews. Committed the changes. Please review

@ansibot
Copy link
Contributor

ansibot commented Jul 5, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:211:29: E128 continuation line under-indented for visual indent

click here for bot help

@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Jul 5, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 5, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:211:33: E127 continuation line over-indented for visual indent

click here for bot help

@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Jul 5, 2019
jillr
jillr reviewed Jul 5, 2019
View reviewed changes
Copy link
Contributor

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm

lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py Outdated Show resolved Hide resolved
lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py Outdated Show resolved Hide resolved
lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py Outdated Show resolved Hide resolved
pgbidkar
pgbidkar commented Jul 9, 2019
View reviewed changes
Copy link
Contributor Author

@pgbidkar pgbidkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handled review comments.

@pgbidkar
Copy link
Contributor Author

pgbidkar commented Jul 9, 2019

Hi @jillr @Akasurde , Thanks for the review comments. Handled review comments. Please review again

Thanks

@goneri goneri mentioned this pull request Jul 9, 2019
Merged
pgbidkar
pgbidkar commented Jul 9, 2019
View reviewed changes
Copy link
Contributor Author

@pgbidkar pgbidkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @goneri, Thanks for review comments. Please let me know your inputs on my queries

Thanks

test/integration/targets/vmware_content_library/content_lib_crud_ops.yml Outdated Show resolved Hide resolved
test/integration/targets/vmware_content_library/content_lib_crud_ops.yml Outdated Show resolved Hide resolved
test/integration/targets/vmware_content_library/aliases Outdated Show resolved Hide resolved
test/integration/targets/vmware_content_library/content_lib_crud_ops.yml Outdated Show resolved Hide resolved
@ansible ansible deleted a comment from pgbidkar Jul 10, 2019
@goneri
Copy link
Contributor

goneri commented Jul 10, 2019

You may find this new doc useful: https://github.com/ansible/ansible/blob/devel/docs/docsite/rst/dev_guide/platforms/vmware_guidelines.rst

It explains how to run the test-suite locally.

pgbidkar
pgbidkar commented Jul 10, 2019
View reviewed changes
Copy link
Contributor Author

@pgbidkar pgbidkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made changes as per review comments

test/integration/targets/vmware_content_library/content_lib_crud_ops.yml Outdated Show resolved Hide resolved
@ansibot
Copy link
Contributor

ansibot commented Jul 10, 2019

The test ansible-test sanity --test pep8 [explain] failed with 8 errors:

lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:211:29: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:217:69: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:220:33: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:221:45: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:222:45: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:223:45: E128 continuation line under-indented for visual indent
lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:224:45: E124 closing bracket does not match visual indentation
lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:282:1: E305 expected 2 blank lines after class or function definition, found 1

click here for bot help

@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 10, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 10, 2019

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:224:47: E124 closing bracket does not match visual indentation
lib/ansible/modules/cloud/vmware/vmware_content_library_manager.py:225:34: E124 closing bracket does not match visual indentation

click here for bot help

@ansibot ansibot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Jul 10, 2019
@pgbidkar pgbidkar force-pushed the content-crud branch 2 times, most recently from b8b58a1 to a816e4b Compare July 10, 2019 13:28
@pgbidkar @Akasurde
New Module for content library CRUD operations
d1025eb 
* Fixing file format issue. converted file from dos2unix
* Review comments changes
* Changes as per review comments. Moved integration test files to module name folder
* Fixed precheck failures
* Fixed few more precheck failures. Visual indentation fix and testname duplication fix in integration fix
@jillr jillr merged commit 7b8edbf into ansible:devel Jul 12, 2019
@ansible ansible locked and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goneri goneri goneri requested changes

@Akasurde Akasurde Akasurde approved these changes

@jillr jillr jillr approved these changes

Assignees

@Akasurde Akasurde

Labels
affects_2.9 This issue/PR affects Ansible v2.9 cloud module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_module This PR includes a new module. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. vmware VMware community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pgbidkar @ansibot @goneri @Akasurde @jillr