Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass allow_unauthenticated when installing a deb directly - allowing unauthenticated dependencies #58771

Merged
merged 2 commits into from
Jul 15, 2019

Conversation

dwyerk
Copy link
Contributor

@dwyerk dwyerk commented Jul 5, 2019

SUMMARY

There is a bug when installing a deb with dependencies in an unauthenticated repo. Normally we can just add allow_unauthenticated to the apt stanza but in the case of a deb file, the allow_unauthenticated setting is ignored. This change passes the value down to the install function so that the setting is no longer ignored.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

apt

ADDITIONAL INFORMATION

Try it out like so:

- name: Add poorly configured repository
  apt_repository:
    repo: "deb http://apt_repo/missing_gpg_signed_Packages"
    state: present

- name: deb with unauthenticated dependencies
  apt:
    deb: ./mypackage.deb
    allow_unauthenticated: yes

@ansibot
Copy link
Contributor

ansibot commented Jul 5, 2019

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. packaging Packaging category small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 5, 2019
@samdoran samdoran changed the title Pass allow_unauthenticated when installing a deb directly - allowing … Pass allow_unauthenticated when installing a deb directly - allowing unauthenticated dependencies Jul 11, 2019
@bcoca bcoca added P3 Priority 3 - Approved, No Time Limitation and removed needs_triage Needs a first human triage before being processed. labels Jul 11, 2019
Copy link
Contributor

@mkrizek mkrizek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Would you mind adding a changelog (see https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to)? I'll merge afterwards. Thanks!

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 12, 2019
@dwyerk
Copy link
Contributor Author

dwyerk commented Jul 12, 2019

@mkrizek Sure thing. Have a look and make sure I got the changelog formatted right.

@ansibot ansibot added support:community This issue/PR relates to code supported by the Ansible community. and removed small_patch labels Jul 12, 2019
@mkrizek mkrizek merged commit ec35cbc into ansible:devel Jul 15, 2019
@ansible ansible locked and limited conversation to collaborators Aug 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. P3 Priority 3 - Approved, No Time Limitation packaging Packaging category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants