Fix exception in unixy callback v2_runner_retry #58801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.9
Akasurde
reviewed
Jul 8, 2019
| @@ -236,6 +236,6 @@ def v2_playbook_on_start(self, playbook): | |||
|
|
|||
| def v2_runner_retry(self, result): | |||
| msg = " Retrying... (%d of %d)" % (result._result['attempts'], result._result['retries']) | |||
| if self._run_is_verbose(result, verbosity=2): | |||
| if self._display.verbosity > 1: | |||
There was a problem hiding this comment.
Suggested change
| if self._display.verbosity > 1: | |
| if self._run_is_verbose(result): |
There was a problem hiding this comment.
Agree with this suggestion, thank you for submitting the patch @jpic
There was a problem hiding this comment.
Done !
Note that line 227 there is self._display.verbosity > 3
https://github.com/ansible/ansible/pull/58801/files#diff-bfc0fb65ff63d5ae485526877e282f97R227
Have a great day
ansibot
removed
the
needs_triage
This fixes the warning: [WARNING]: Failure using method (v2_runner_retry) in callback plugin (<ansible.plugins.callback.unixymdv.CallbackModule object at 0x7fb4fd4eeef0>): _run_is_verbose() got an unexpected keyword argument 'verbosity'
|
shipit
|
ansibot
added
shipit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the warning:
SUMMARY
Fixes a little exception, probably on code that needed update
ISSUE TYPE
COMPONENT NAME
unixy callback plugin
ADDITIONAL INFORMATION