Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if users are None/empty, dont assume sameness #58875

Merged
merged 1 commit into from Jul 17, 2019
Merged

if users are None/empty, dont assume sameness #58875

merged 1 commit into from Jul 17, 2019

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Jul 9, 2019

prevents None == None cases in which 'defaults' for remote and become differ

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

actions

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 9, 2019
@bcoca bcoca requested review from sivel and samdoran July 9, 2019 17:20
@sivel
Copy link
Member

sivel commented Jul 9, 2019

We should probably extend the tests in test_action_base_sudo_only_if_user_differs at test/units/plugins/action/test_action.py to test this logic.

@bcoca
Copy link
Member Author

bcoca commented Jul 9, 2019

and add clog, was just seeing if all current tests passed

samdoran
samdoran suggested changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@samdoran samdoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely need test cases for this. It's pretty hard to follow this logic even when it is broken out into a separate method.

lib/ansible/plugins/action/__init__.py Show resolved Hide resolved
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 9, 2019
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jul 11, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 17, 2019
@bcoca bcoca merged commit 4ef2545 into ansible:devel Jul 17, 2019
@bcoca bcoca deleted the become_none branch July 17, 2019 15:18
bcoca added a commit to bcoca/ansible that referenced this pull request Jul 22, 2019
@bcoca
if users are None/empty, dont assume sameness (ansible#58875)
1799be2 
(cherry picked from commit 4ef2545)

 also fix all cases of none remote/become users (ansible#59397)
 some cases failed, when defaults were None on the plugins

(cherry picked from commit 74ac229)
abadger pushed a commit that referenced this pull request Jul 23, 2019
@bcoca @abadger
if users are None/empty, dont assume sameness (#58875)
37f8684 
(cherry picked from commit 4ef2545)

 also fix all cases of none remote/become users (#59397)
 some cases failed, when defaults were None on the plugins

(cherry picked from commit 74ac229)
@ansible ansible locked and limited conversation to collaborators Aug 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samdoran samdoran samdoran approved these changes

@sivel sivel Awaiting requested review from sivel

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bcoca @sivel @samdoran @ansibot