Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update azure_rm_virtualmachinescalesetinstance related document #58909

Merged
merged 2 commits into from
Jul 12, 2019
Merged

Update azure_rm_virtualmachinescalesetinstance related document #58909

merged 2 commits into from
Jul 12, 2019

Conversation

Fred-sun
Copy link
Contributor

SUMMARY

Update azure_rm_virtualmachinescalesetinstance related document.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

azure_rm_virtualmachinescalesetinstance/azure_rm_virtualmachinescalesetinstance_facts

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Jul 10, 2019

cc @haroldwongms @nitzmahone @trstringer @yungezz @yuwzho @zikalino
click here for bot help

@ansibot
Copy link
Contributor

ansibot commented Jul 10, 2019

@Fred-sun, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 azure cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Jul 10, 2019
@ansibleazurebot ansibleazurebot mentioned this pull request Jul 11, 2019
Closed
@Fred-sun
Copy link
Contributor Author

ready_for_review

acozine
acozine reviewed Jul 11, 2019
View reviewed changes
Copy link
Contributor

@acozine acozine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return values suggest that a VM Scale Set Instance is just a VM . . . if that isn't true, those docs, might need a little more specificity. But overall, looks good. Thanks @Fred-sun.

lib/ansible/modules/cloud/azure/azure_rm_virtualmachinescalesetinstance.py Outdated Show resolved Hide resolved
@acozine acozine removed the needs_triage Needs a first human triage before being processed. label Jul 11, 2019
@acozine acozine merged commit 8c55a9c into ansible:devel Jul 12, 2019
@Fred-sun Fred-sun deleted the azure_rm_virtualmachinescalesetinstance branch July 18, 2019 02:47
@ansible ansible locked and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acozine acozine acozine left review comments

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 azure cloud community_review In order to be merged, this PR must follow the community review workflow. docs This issue/PR relates to or includes documentation. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Fred-sun @ansibot @acozine