Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip: Remove unused option use_mirrors and remove all ignore.txt entries #58977

Merged
merged 2 commits into from
Jul 18, 2019

Conversation

hannseman
Copy link
Contributor

SUMMARY

This PR removes the unused option use_mirrors. I've tried to find when this option was actually used but I couldn't find it, I guess it predates the current mono-repo? Anyway since this option hasn't been documented for at least the last 4 current major versions it should be alright to be removed.

Together with #58966 this allows us to remove all ignored sanity checks from ignore.txt. This PR will keep failing until #58966 is merged this branch is rebased.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

pip

@hannseman hannseman changed the title pip: Remove unused option use_mirrors and remove all ignore.txt entries [WIP] pip: Remove unused option use_mirrors and remove all ignore.txt entries Jul 11, 2019
@hannseman hannseman closed this Jul 11, 2019
@hannseman hannseman reopened this Jul 11, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 11, 2019

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. packaging Packaging category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jul 11, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 11, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 11 errors:

lib/ansible/modules/packaging/language/pip.py:0:0: E337 Argument 'chdir' in argument_spec defines type as 'path' but documentation doesn't define type
lib/ansible/modules/packaging/language/pip.py:0:0: E337 Argument 'executable' in argument_spec defines type as 'path' but documentation doesn't define type
lib/ansible/modules/packaging/language/pip.py:0:0: E337 Argument 'extra_args' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/packaging/language/pip.py:0:0: E337 Argument 'name' in argument_spec defines type as 'list' but documentation doesn't define type
lib/ansible/modules/packaging/language/pip.py:0:0: E337 Argument 'requirements' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/packaging/language/pip.py:0:0: E337 Argument 'state' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/packaging/language/pip.py:0:0: E337 Argument 'umask' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/packaging/language/pip.py:0:0: E337 Argument 'version' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/packaging/language/pip.py:0:0: E337 Argument 'virtualenv' in argument_spec defines type as 'path' but documentation doesn't define type
lib/ansible/modules/packaging/language/pip.py:0:0: E337 Argument 'virtualenv_command' in argument_spec defines type as 'path' but documentation doesn't define type
lib/ansible/modules/packaging/language/pip.py:0:0: E337 Argument 'virtualenv_python' in argument_spec defines type as 'str' but documentation doesn't define type

click here for bot help

@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jul 11, 2019
@webknjaz
Copy link
Member

@hannseman this is ready for rebasing :)

@hannseman hannseman changed the title [WIP] pip: Remove unused option use_mirrors and remove all ignore.txt entries pip: Remove unused option use_mirrors and remove all ignore.txt entries Jul 13, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Jul 13, 2019
@hannseman
Copy link
Contributor Author

Rebased and ready_for_review :)

@webknjaz webknjaz merged commit 0e8eb1d into ansible:devel Jul 18, 2019
@hannseman
Copy link
Contributor Author

@webknjaz thanks for the review! :)

@ansible ansible locked and limited conversation to collaborators Aug 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. packaging Packaging category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants